libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java - Issue 29536604: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java

Issue 29536604: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: address comment Created Sept. 7, 2017, 12:54 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java ('K') | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java ('k') | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java

similarity index 88%

rename from libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java

rename to libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java

index fc988be5c4d82ac6816b86909cb9f0f1f0ff01bb..2f512c2ea5a77ddec4fac9aa8fa7d180acbad844 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java

@@ -27,7 +27,7 @@ import org.adblockplus.libadblockplus.WebRequest;

import android.content.Context;

import android.test.InstrumentationTestCase;

-public abstract class BaseJsTest extends InstrumentationTestCase

+public abstract class BaseJsEngineTest extends InstrumentationTestCase

{

protected JsEngine jsEngine;

@@ -40,6 +40,16 @@ public abstract class BaseJsTest extends InstrumentationTestCase

getContext().getFilesDir().getAbsolutePath());

}

+ @Override

+ protected void tearDown() throws Exception

+ {

+ if (jsEngine != null)

+ {

+ jsEngine.dispose();

+ jsEngine = null;

+ }

// If the method returns null then a default implementation of the Log System

// provided by libadblockplus is used.

protected LogSystem createLogSystem()