libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java - Issue 29536604: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

Issue 29536604: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: address comment Created Sept. 7, 2017, 12:54 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java ('K') | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackImplTest.java ('k') | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsEngineTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

index c7e1a5ece6f449a80ace740bd2a36b43500da3da..6b71cef6ec749858f7fa602f18286b86bfd74194 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

@@ -19,9 +19,11 @@ package org.adblockplus.libadblockplus.tests;

import android.os.SystemClock;

+import org.adblockplus.libadblockplus.AppInfo;

import org.adblockplus.libadblockplus.FilterEngine;

import org.adblockplus.libadblockplus.HeaderEntry;

import org.adblockplus.libadblockplus.IsAllowedConnectionCallback;

+import org.adblockplus.libadblockplus.JsEngine;

import org.adblockplus.libadblockplus.ServerResponse;

import org.adblockplus.libadblockplus.Subscription;

import org.adblockplus.libadblockplus.WebRequest;

@@ -31,7 +33,7 @@ import org.junit.Test;

import java.util.LinkedList;

import java.util.List;

-public class IsAllowedConnectionCallbackTest extends BaseJsTest

+public class IsAllowedConnectionCallbackTest extends BaseFilterEngineTest

{

private static final int UPDATE_SUBSCRIPTIONS_WAIT_DELAY_MS = 5 * 1000; // 5s

@@ -90,13 +92,12 @@ public class IsAllowedConnectionCallbackTest extends BaseJsTest

private TestRequest request;

private TestCallback callback;

- private FilterEngine filterEngine;

@Override

protected void setUp() throws Exception

{

- super.setUp();

+ jsEngine = new JsEngine(AppInfo.builder().build(), createLogSystem(), createWebRequest(),

+ getContext().getFilesDir().getAbsolutePath());

callback = new TestCallback();

filterEngine = new FilterEngine(jsEngine, callback);

}