libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java - Issue 29536604: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java

Issue 29536604: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: address comment Created Sept. 7, 2017, 12:54 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java ('K') | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java ('k') | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java

index cc8b6acda05c6ce70c2feeaf4c47bfbbddeb8c39..8e482f809539f2d123c07b850b7f948cae1e3e04 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java

@@ -21,19 +21,17 @@ import org.adblockplus.libadblockplus.AppInfo;

import org.adblockplus.libadblockplus.FilterEngine;

import org.adblockplus.libadblockplus.JsEngine;

import org.adblockplus.libadblockplus.MockWebRequest;

+import org.adblockplus.libadblockplus.WebRequest;

import android.test.AndroidTestCase;

-public class UpdaterTest extends AndroidTestCase

+public class UpdaterTest extends BaseFilterEngineTest

{

protected MockWebRequest mockWebRequest;

- protected FilterEngine filterEngine;

@Override

protected void setUp() throws Exception

{

- super.setUp();

AppInfo appInfo = AppInfo

.builder()

.setName("test")

@@ -41,7 +39,7 @@ public class UpdaterTest extends AndroidTestCase

.build();

mockWebRequest = new MockWebRequest();

- JsEngine jsEngine = new JsEngine(appInfo, null, mockWebRequest,

+ jsEngine = new JsEngine(appInfo, null, mockWebRequest,

getContext().getFilesDir().getAbsolutePath());

filterEngine = new FilterEngine(jsEngine);