libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java - Issue 29536629: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

Issue 29536629: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: address comments Created Sept. 8, 2017, 9:39 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java ('k') | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

index a82e0f05cb4c651ddf7a0dc05ddb448e714b0708..4023a79a091959c578d7173c6f01a3dcccc9879b 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

@@ -22,7 +22,7 @@ import org.adblockplus.libadblockplus.JsEngine;

import org.junit.Test;

-public class AppInfoJsObjectTest extends BaseJsEngineTest

+public class AppInfoJsObjectTest extends BasePlatformTest

{

@Test

public void testAllProperties()

@@ -37,7 +37,8 @@ public class AppInfoJsObjectTest extends BaseJsEngineTest

.setDevelopmentBuild(true)

.build();

- JsEngine jsEngine = new JsEngine(appInfo);

+ platform.setUpJsEngine(appInfo);

+ JsEngine jsEngine = platform.getJsEngine();

assertEquals("1", jsEngine.evaluate("_appInfo.version").asString());

assertEquals("3", jsEngine.evaluate("_appInfo.name").asString());

assertEquals("4", jsEngine.evaluate("_appInfo.application").asString());

@@ -52,8 +53,8 @@ public class AppInfoJsObjectTest extends BaseJsEngineTest

AppInfo appInfo = AppInfo

.builder()

.build();

- JsEngine jsEngine = new JsEngine(appInfo);

+ platform.setUpJsEngine(appInfo);

+ JsEngine jsEngine = platform.getJsEngine();

assertEquals("1.0", jsEngine.evaluate("_appInfo.version").asString());

assertEquals("libadblockplus-android", jsEngine.evaluate("_appInfo.name").asString());

assertEquals("android", jsEngine.evaluate("_appInfo.application").asString());