Issue 5587, 5748 - Use mobile options page on Firefox for Android

lib/browserAction.js

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/** @module browserAction */
+
+"use strict";
+
+const {getDecodedHostname} = require("url");
+const {checkWhitelisted} = require("whitelisting");
+
+// On Firefox for Android, open the options page directly when the browser
+// action is clicked.
+chrome.browserAction.onClicked.addListener(() =>

[Manish Jethani, 2017/09/07 11:04:16]

Note: We don't have to check for "fennec" here, because the handler simply won't
be called on desktop since there already is a popup associated with the browser
action.

+{
+  ext.pages.query({active: true, lastFocusedWindow: true}, pages =>
+  {
+    let currentPage = pages[0];
+
+    ext.showOptions(optionsPage =>
+    {
+      if (!["http:", "https:"].includes(currentPage.url.protocol))

[Manish Jethani, 2017/09/07 11:04:16]

Now checking specifically for HTTP and HTTPS.

[Sebastian Noack, 2017/09/07 16:36:45]

It would be great if we could reuse the same code here as we do in the popup to
determine whether the current page can be whitelisted and whether it already is.

[Manish Jethani, 2017/09/08 10:02:24]

From what I can tell the code here is nearly identical to that in popup.js

https://hg.adblockplus.org/adblockpluschrome/file/18983acc26fe/popup.js#l36
https://hg.adblockplus.org/adblockpluschrome/file/18983acc26fe/popup.js#l58

[Sebastian Noack, 2017/09/11 22:40:02]

What I meant was to avoid duplicating the logic here and in popup.js. But it's
probably not worth to be wrapped into a module or something. So never mind.

+        return;
+
+      optionsPage.sendMessage({
+        type: "app.respond",
+        action: "showPageOptions",
+        args: [
+          {
+            host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),

[Manish Jethani, 2017/09/07 11:04:16]

Using getDecodedHostname here so we can handle Unicode hostnames, similar to how
popup.js does it.

+            whitelisted: checkWhitelisted(currentPage)
+          }
+        ]
+      });
+    });
+  });
+});