Issue 5587, 5748 - Use mobile options page on Firefox for Android

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 299 matching lines @@
   chrome.tabs.onRemoved.addListener(forgetTab);
 
   chrome.tabs.onActivated.addListener(details =>
   {
     ext.pages.onActivated._dispatch(new Page({id: details.tabId}));
   });
 
 
   /* Browser actions */
 
-  // On Firefox for Android, open the options page directly when the browser
-  // action is clicked.
-  if (!("getPopup" in chrome.browserAction))
-  {
-    chrome.browserAction.onClicked.addListener(() =>
-    {
-      ext.showOptions();
-    });
-  }
-
   let BrowserAction = function(tabId)
   {
     this._tabId = tabId;
     this._changes = null;
   };
   BrowserAction.prototype = {
     _applyChanges()
     {
       if ("iconPath" in this._changes)
       {
@@ skipping 385 matching lines @@
             {
               if (tabs[0].status == "complete")
                 callback(new Page(tabs[0]));
               else
                 afterTabLoaded(callback)(tabs[0]);
             }
           });
         });
       }
     }
-    else if ("windows" in chrome)
+    else
     {
       // Edge does not yet support runtime.openOptionsPage (tested version 38)
-      // and so this workaround needs to stay for now.
-      // We are not using extension.getURL to get the absolute path here
-      // because of the Edge issue:
-      // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
-      let optionsUrl = "options.html";
-      let fullOptionsUrl = ext.getURL(optionsUrl);
-
       chrome.tabs.query({}, tabs =>
       {
         // We find a tab ourselves because Edge has a bug when quering tabs
         // with extension URL protocol:
         // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8094141/ 
         // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8604703/
+        // Firefox won't let us query for moz-extension:// pages either, though
+        // starting with Firefox 56 an extension can query for its own URLs:
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=1271354
+        let optionsUrl = "options.html";
+        let fullOptionsUrl = ext.getURL(optionsUrl);
         let tab = tabs.find(element => element.url == fullOptionsUrl);
         if (tab)
         {
-          chrome.windows.update(tab.windowId, {focused: true});
+          // Firefox for Android before version 57 does not support
+          // runtime.openOptionsPage, nor does it support the windows API.
+          // Since there is effectively only one window on the mobile browser,
+          // there's no need to bring it into focus.
+          if ("windows" in chrome)
+            chrome.windows.update(tab.windowId, {focused: true});
+
           chrome.tabs.update(tab.id, {active: true});
 
           if (callback)
-            callback(new Page(tab));
+          {

[Manish Jethani, 2017/09/15 17:57:27]

This should be done regardless of the other changes.

+            if (tab.status == "complete")
+              callback(new Page(tab));
+            else
+              afterTabLoaded(callback)(tab);
+          }
         }
         else
         {
+          // We don't use fullOptionsUrl here because of this Edge issue:
+          // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332
           ext.pages.open(optionsUrl, callback);
         }
       });
     }
-    else
-    {
-      // Firefox for Android before version 57 does not support
-      // runtime.openOptionsPage, nor does it support the windows API. Since
-      // there is effectively only one window on the mobile browser, there's no
-      // need to bring it into focus.
-      ext.pages.open("options.html", callback);
-    }
   };
 
   /* Windows */
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());