Issue 5587, 5748 - Use mobile options page on Firefox for Android

lib/browserAction.js

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/** @module browserAction */

[Sebastian Noack, 2017/09/27 01:38:35]

Perhaps, this code can go into lib/options.js as well now?

[Manish Jethani, 2017/09/27 11:20:55]

For now it could, but technically "browser action" is different than "options",
it's actually more related to the popup than the options page (only on mobile we
open the options page directly), therefore maybe it's good to just leave it
here. If we want to get rid of ext/background.js eventually then the
BrowserAction class would end up here, I think.

[Sebastian Noack, 2017/09/30 02:38:43]

We would not preserve the BrowserAction class as it is. It only exists as a
class so that it can be a property on the Page object, which should go away as
well. However, we might need to keep a wrapper around the
chrome.tabs.browserAction.set* APIs, to keep working around the issue when the
tab is pre-rendered, unless this isn't necessary anymore, or we find a better
way to deal with it.

Anyway, for the time being, I prefer to not put every single tiny piece of code
into their separate module, and the code here is arguably related to the
options. That we use the browserAction API here is rather an implementation
detail, but the code isn't any more related to any other code we might move in
here in the future, than the code now added with the "options" module.

[Manish Jethani, 2017/09/30 13:49:51]

Done.

+
+"use strict";
+
+const {getDecodedHostname} = require("url");
+const {checkWhitelisted} = require("whitelisting");
+const {showOptions} = require("options");
+
+// On Firefox for Android, open the options page directly when the browser
+// action is clicked.
+chrome.browserAction.onClicked.addListener(() =>
+{
+  ext.pages.query({active: true, lastFocusedWindow: true}, pages =>
+  {
+    let currentPage = pages[0];
+
+    showOptions(optionsPage =>
+    {
+      if (!["http:", "https:"].includes(currentPage.url.protocol))
+        return;
+
+      optionsPage.sendMessage({
+        type: "app.respond",
+        action: "showPageOptions",
+        args: [
+          {
+            host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),
+            whitelisted: !!checkWhitelisted(currentPage)
+          }
+        ]
+      });
+    });
+  });
+});