metadata.gecko-webext - Issue 29536764: Issue 5587, 5748 - Use mobile options page on Firefox for Android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.gecko-webext

Issue 29536764: Issue 5587, 5748 - Use mobile options page on Firefox for Android (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Add options page loader Created Sept. 8, 2017, 9:59 a.m.

Right Patch Set: Remove workaround for FOUC issue and update adblockplusui dependency Created Oct. 5, 2017, 1:24 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}	5 id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

6 basename = adblockplusfirefox	6 basename = adblockplusfirefox

7 version = 2.99.0	7 version = 2.99.0

8 # Firefox has a different options page depending on whether it's desktop or
Manish Jethani 2017/09/08 10:02:25 Now Firefox has a different file for the options p Now Firefox has a different file for the options page, which then loads the actual options page. Manish Jethani 2017/09/08 10:46:45 And there's no need for this now. All browsers wil Show quoted text On 2017/09/08 10:02:25, Manish Jethani wrote: > Now Firefox has a different file for the options page, which then loads the > actual options page. And there's no need for this now. All browsers will have the same options page, the one that embeds either desktop-options.html or mobile-options.html.
9 # mobile.

10 options = options-loader.html

11	8

12 [compat]	9 [compat]

13 gecko = 50.0	10 gecko = 50.0

14	11

15 [mapping]	12 [mapping]

16 mobile-options.html = adblockplusui/mobile-options.html	13 mobile-options.html = adblockplusui/mobile-options.html

17 mobile-options.js = adblockplusui/mobile-options.js	14 mobile-options.js = adblockplusui/mobile-options.js

18 skin/abp-logo.svg = adblockplusui/skin/abp-logo.svg	15 skin/abp-logo.svg = adblockplusui/skin/abp-logo.svg

19 skin/mobile-options.css = adblockplusui/skin/mobile-options.css	16 skin/mobile-options.css = adblockplusui/skin/mobile-options.css

20 skin/mobile/checkmark.svg = adblockplusui/skin/mobile/checkmark.svg	17 skin/mobile/checkmark.svg = adblockplusui/skin/mobile/checkmark.svg

21 skin/mobile/toggle.svg = adblockplusui/skin/mobile/toggle.svg	18 skin/mobile/toggle.svg = adblockplusui/skin/mobile/toggle.svg

22 skin/mobile/trash.svg = adblockplusui/skin/mobile/trash.svg	19 skin/mobile/trash.svg = adblockplusui/skin/mobile/trash.svg

23	20

24 [convert_js]	21 [convert_js]

25 # See https://bugzil.la/1190687 - pop-up blocking won't work right now

26 lib/adblockplus.js -= lib/popupBlocker.js

27 lib/adblockplus.js += lib/firefoxDataCleanup.js	22 lib/adblockplus.js += lib/firefoxDataCleanup.js

28 lib/adblockplus.js += lib/browserAction.js

29	23

30 [import_locales]	24 [import_locales]

31 adblockplusui/locale//mobile-options.json = =	25 adblockplusui/locale//mobile-options.json = =

LEFT	RIGHT