Issue 5587, 5748 - Use mobile options page on Firefox for Android

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-const {require} = chrome.extension.getBackgroundPage();

[Sebastian Noack, 2017/09/27 01:38:34]

Note that when we are using webpack soon, we can only use require() in scripts
that are part of the bundle.

However, you can request the info that you need here asynchronously with the
following message:

  {type: "app.get", what: "application"}

[Manish Jethani, 2017/09/27 11:20:54]

I see.
OK.

Perhaps there should be a stateless version lib/adblockplus.js that includes
things like the info module and some utility classes/functions, then we can
include it in the popup and the options page and not have to use messaging for
every little thing.

[Sebastian Noack, 2017/09/30 02:38:43]

If it is just for the info module, I don't think it is too bad having to use
asynchronous messaging the couple few times we need to query these information
from outside the background page. And I wouldn't know for which other logic we
could potentially avoid messaging, by redundantly including the code.

Also note that on Firefox, application and applicationVersion is retrieved from
an async APIs. By the time the options page is opened it is safe to assume,
these information are available in the background page, but if we would just
include the same code here, we would have to wait, which isn't any less
complicated than just asking the background page.

Anyway, the latest patch set still uses
chrome.extension.getBackgroundPage().require(). We should change this.

[Manish Jethani, 2017/09/30 13:49:51]

Done.

-
 let iframe = document.getElementById("content");
 
 iframe.onload = () =>
 {
   document.title = iframe.contentDocument.title;
 };
 
-// Load the mobile version of the options page on Firefox for Android.
-iframe.src = iframe.getAttribute("data-src-" + require("info").application) ||
-             iframe.getAttribute("data-src");
+chrome.runtime.sendMessage({

[Oleksandr, 2017/10/09 11:49:59]

Edge does not support the 'chrome' namespace for extensions. We should map to
'browser' here instead.

[Manish Jethani, 2017/10/09 12:00:55]

Thanks.

[Sebastian Noack, 2017/10/09 15:09:55]

Note that we already do so in ext/common.js:
https://hg.adblockplus.org/adblockpluschrome/file/7136ad8e321d/ext/common.js#l22

+  type: "app.get",
+  what: "application"
+},
+application =>
+{
+  // Load the mobile version of the options page on Firefox for Android.
+  iframe.src = iframe.getAttribute("data-src-" + application) ||
+               iframe.getAttribute("data-src");
+});