Issue 5587, 5748 - Use mobile options page on Firefox for Android

lib/options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 41 matching lines @@
     callback(new ext.Page(optionsTab));
   }
   else
   {
     // If we don't already have an options page, it means we've just opened
     // one, in which case we must find the tab, wait for it to be ready, and
     // then return the call.
     findOptionsTab(tab =>
     {
       if (!tab)
-      {
-        // This likely means that there was an error.

[Sebastian Noack, 2017/10/04 05:33:15]

I think this comment should rather be:

  This means that there was either an error or that the
  options page has been closed right away.

Also, I'd put the comment above the if statement, and then remove the braces.

[Manish Jethani, 2017/10/04 13:02:46]

OK, I'd rather just lose that comment.

Done.

         return;
-      }
 
       function onMessage(message, sender)
       {
         if (message.type == "app.listen" &&
             sender.page && sender.page.id == tab.id)
         {
           port.off("app.listen", onMessage);
           callback(new ext.Page(tab));
         }
       }
@@ skipping 70 matching lines @@
         args: [
           {
             host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),
             whitelisted: !!checkWhitelisted(currentPage)
           }
         ]
       });
     });
   });
 });