options.html - Issue 29536764: Issue 5587, 5748 - Use mobile options page on Firefox for Android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: options.html

Issue 29536764: Issue 5587, 5748 - Use mobile options page on Firefox for Android (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Hide content frame until loaded Created Oct. 4, 2017, 9:56 p.m.

Right Patch Set: Remove workaround for FOUC issue and update adblockplusui dependency Created Oct. 5, 2017, 1:24 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2	2

3 <!--	3 <!--

4 - This file is part of Adblock Plus <https://adblockplus.org/>,	4 - This file is part of Adblock Plus <https://adblockplus.org/>,

5 - Copyright (C) 2006-present eyeo GmbH	5 - Copyright (C) 2006-present eyeo GmbH

6 -	6 -

7 - Adblock Plus is free software: you can redistribute it and/or modify	7 - Adblock Plus is free software: you can redistribute it and/or modify

8 - it under the terms of the GNU General Public License version 3 as	8 - it under the terms of the GNU General Public License version 3 as

9 - published by the Free Software Foundation.	9 - published by the Free Software Foundation.

10 -	10 -

(...skipping 21 matching lines...) Expand all Loading...
32 {	32 {

33 border: none;	33 border: none;

34 position: fixed;	34 position: fixed;

35 width: 100%;	35 width: 100%;

36 height: 100%;	36 height: 100%;

37 }	37 }

38 </style>	38 </style>

39 <script src="options.js" defer></script>	39 <script src="options.js" defer></script>

40 </head>	40 </head>

41 <body>	41 <body>

42 <iframe id="content" style="visibility: hidden" data-src="desktop-options.ht ml" data-src-fennec="mobile-options.html"></iframe>	42 <iframe id="content" data-src="desktop-options.html" data-src-fennec="mobile -options.html"></iframe>
Sebastian Noack 2017/10/04 22:36:19 Using style attributes isn't great. A more semanti Using style attributes isn't great. A more semantic (better) way to achieve the same seems to be the "hidden" attribute: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden Manish Jethani 2017/10/04 23:07:52 The hidden attribute doesn't seem to be as effecti Show quoted text On 2017/10/04 22:36:19, Sebastian Noack wrote: > Using style attributes isn't great. A more semantic (better) way to achieve the > same seems to be the "hidden" attribute: > https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden The hidden attribute doesn't seem to be as effective in avoiding the flash of unstyled content. I'm guessing this is because it has different semantics. It's more like setting the "display" style to "none". "hidden" is semantic: https://html.spec.whatwg.org/multipage/interaction.html#the-hidden-attribute It just so happens that browsers hide "hidden" elements by default. If you override the "display" style of a "hidden" element by setting it to "block", it'll be visible again (even though its Element.hidden will still be true). Anyway, we don't want to remove the element from the document's layout, and we don't want to hide the element from screen readers and such, which is what setting "hidden" would do. We only want to hide the element visually (not semantically), in this case setting the style is in fact the correct way to do it.
43 </body>	43 </body>

44 </html>	44 </html>

LEFT	RIGHT