Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/notificationHelper.js

Issue 29536764: Issue 5587, 5748 - Use mobile options page on Firefox for Android (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Set content size Created Oct. 4, 2017, 3:54 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/background.js ('k') | lib/options.js » ('j') | lib/options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/notificationHelper.js
===================================================================
--- a/lib/notificationHelper.js
+++ b/lib/notificationHelper.js
@@ -20,16 +20,17 @@
"use strict";
const {startIconAnimation, stopIconAnimation} = require("icon");
const {Utils} = require("utils");
const {Notification: NotificationStorage} = require("notification");
const {stringifyURL} = require("url");
const {initAntiAdblockNotification} = require("antiadblockInit");
const {Prefs} = require("prefs");
+const {showOptions} = require("options");
let activeNotification = null;
let activeButtons = null;
let defaultDisplayMethods = ["popup"];
let displayMethods = Object.create(null);
displayMethods.critical = ["icon", "notification", "popup"];
displayMethods.question = ["notification"];
displayMethods.normal = ["notification"];
@@ -118,17 +119,17 @@
case "link":
ext.pages.open(Utils.getDocLink(activeNotification.links[buttonIndex]));
break;
case "open-all":
openNotificationLinks();
break;
case "configure":
Prefs.notifications_showui = true;
- ext.showOptions(page =>
+ showOptions(page =>
{
page.sendMessage({
type: "app.respond",
action: "focusSection",
args: ["notifications"]
});
});
break;
« no previous file with comments | « ext/background.js ('k') | lib/options.js » ('j') | lib/options.js » ('J')

Powered by Google App Engine
This is Rietveld