c++/clang-format/clang-format-eyeo - Issue 29537634: Noissue - clang-format configuration file for C++

Side by Side Diff: c++/clang-format/clang-format-eyeo

Issue 29537634: Noissue - clang-format configuration file for C++

Patch Set: Created Sept. 6, 2017, 1:44 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ---

	2 Language: Cpp

	3 AccessModifierOffset: -2
	sergei 2017/09/08 15:10:44 I think we should add AlignAfterOpenBracket: DontA I think we should add AlignAfterOpenBracket: DontAlign Eric 2017/09/08 15:48:34 The Mozilla style guide uses examples where the va Show quoted text On 2017/09/08 15:10:44, sergei wrote: > I think we should add > AlignAfterOpenBracket: DontAlign The Mozilla style guide uses examples where the value would be "Align". A dump of the Mozilla style within `clang-format` has the value "Align". I've added the "Align" value. We can change the Eyeo coding style, but that's out of scope for this change.
	4 AlignEscapedNewlinesLeft: false

	5 AlignTrailingComments: true

	6 AllowAllParametersOfDeclarationOnNextLine: false

	7 AllowShortBlocksOnASingleLine: false

	8 AllowShortFunctionsOnASingleLine: All

	9 AllowShortIfStatementsOnASingleLine: false

	10 AllowShortLoopsOnASingleLine: false

	11 AlwaysBreakBeforeMultilineStrings: false

	12 AlwaysBreakTemplateDeclarations: true

	13 BinPackParameters: true

	14 BreakBeforeBinaryOperators: false

	15 BreakBeforeBraces: Allman

	16 BreakBeforeTernaryOperators: false

	17 BreakConstructorInitializersBeforeComma: false

	18 ColumnLimit: 0
	hub 2017/09/06 14:42:42 Should we have a column limit like 80 ? it is loos Should we have a column limit like 80 ? it is loosely applied, but 0 make some line being unwrapped. Eric 2017/09/08 15:48:34 I tried column limits before, and it wasn't practi Show quoted text On 2017/09/06 14:42:42, hub wrote: > Should we have a column limit like 80 ? it is loosely applied, but 0 make some > line being unwrapped. I tried column limits before, and it wasn't practicable, not at the outset. A bunch of old code suddenly looked far worse. Lot's of lines that had been ~ 81-90 characters got orphaned second lines. Etc. Since this is an initial commit, it's more conservative not to enforce this one yet. I'm thinking we need a script wrapper around the use case of reformatting long lines. hub 2017/09/08 16:02:45 this actually unwrap manually wrapped lines. So ma Show quoted text On 2017/09/08 15:48:34, Eric wrote: > On 2017/09/06 14:42:42, hub wrote: > > Should we have a column limit like 80 ? it is loosely applied, but 0 make some > > line being unwrapped. > > I tried column limits before, and it wasn't practicable, not at the outset. A > bunch of old code suddenly looked far worse. Lot's of lines that had been ~ > 81-90 characters got orphaned second lines. Etc. > > Since this is an initial commit, it's more conservative not to enforce this one > yet. I'm thinking we need a script wrapper around the use case of reformatting > long lines. this actually unwrap manually wrapped lines. So maybe a different approach would be to ensure it doesn't unwrap. Not sure which option.
	19 CommentPragmas: '^ IWYU pragma:'

	20 ConstructorInitializerAllOnOneLineOrOnePerLine: true

	21 ConstructorInitializerIndentWidth: 2

	22 ContinuationIndentWidth: 2

	23 Cpp11BracedListStyle: true

	24 DerivePointerAlignment: false

	25 DisableFormat: false

	26 ExperimentalAutoDetectBinPacking: false

	27 ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH ]

	28 IndentCaseLabels: false
	hub 2017/09/06 14:56:51 This should be "true" False turns ``` switch () This should be "true" False turns ``` switch () { case 1: ``` to ``` switch () { case 1: ``` I have seen the later style though (in a few instances), so we should just settle on one and set this options accordingly. Eric 2017/09/08 15:48:34 I changed this one to conform to the Mozilla style I changed this one to conform to the Mozilla style guide. As I recall, this was to deal with legacy ablockplusie code or Visual Studio default (I forget which) that used the other style.
	29 IndentFunctionDeclarationAfterType: false

	30 IndentWidth: 2

	31 IndentWrappedFunctionNames: false

	32 KeepEmptyLinesAtTheStartOfBlocks: false

	33 MaxEmptyLinesToKeep: 1

	34 NamespaceIndentation: All

	35 PenaltyBreakBeforeFirstCallParameter: 19

	36 PenaltyBreakComment: 300

	37 PenaltyBreakFirstLessLess: 120

	38 PenaltyBreakString: 1000

	39 PenaltyExcessCharacter: 1000000

	40 PenaltyReturnTypeOnItsOwnLine: 200

	41 PointerAlignment: Left

	42 SpaceBeforeAssignmentOperators: true

	43 SpaceBeforeParens: ControlStatements

	44 SpaceInEmptyParentheses: false

	45 SpacesBeforeTrailingComments: 1

	46 SpacesInAngles: false

	47 SpacesInContainerLiterals: true

	48 SpacesInCStyleCastParentheses: false

	49 SpacesInParentheses: false

	50 SpacesInSquareBrackets: false

	51 Standard: Cpp11

	52 TabWidth: 8

	53 UseTab: Never

	54 ...

	55

OLD	NEW

« no previous file with comments | « c++/clang-format/README.md ('k') | no next file » | no next file with comments »