Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29537638: Issue 6226 - Use mesonbuild as a build system (Closed)

Created:
Sept. 6, 2017, 2:27 p.m. by hub
Modified:
Aug. 7, 2018, 5:39 p.m.
Reviewers:
sergei
CC:
anton
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 6226 - Use mesonbuild as a build system [DONE] Currently build libadblockplus and run the test [almost DONE] Needs to ensure it builds with Windows [DONE] Needs to ensure we can build for Android Also can be adapted to build adblockpluscore as a subproject when we start using the emscripten code.

Patch Set 1 #

Patch Set 2 : Now mostly functional #

Patch Set 3 : Missing wrap_make. Added Win32 support (untested) #

Patch Set 4 : Handle arch properly. #

Patch Set 5 : Fix more build issues, cross compile. #

Patch Set 6 : Cross compiling for Android on macOS works. #

Patch Set 7 : Extract the NDK in the right place. #

Patch Set 8 : Support NDK r16b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -3 lines) Patch
M .hgignore View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M .travis.yml View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M README.md View 1 2 3 4 5 3 chunks +44 lines, -2 lines 0 comments Download
A cross-bootstrap.sh View 1 2 3 4 5 6 7 1 chunk +46 lines, -0 lines 0 comments Download
A cross/r16b/android-arm.in View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
A cross/r16b/android-arm64.in View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
A cross/r16b/android-x86.in View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 0 comments Download
A meson.build View 1 2 3 4 5 6 7 1 chunk +277 lines, -0 lines 0 comments Download
A wrap_make View 1 2 3 4 5 1 chunk +53 lines, -0 lines 0 comments Download
A wrap_make_gyp View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13
hub
Sept. 6, 2017, 2:27 p.m. (2017-09-06 14:27:12 UTC) #1
hub
This is not functional yet.
Sept. 6, 2017, 2:27 p.m. (2017-09-06 14:27:33 UTC) #2
Felix Dahlke
1) I don't think switching build systems should be done without an issue that has ...
Dec. 21, 2017, 10:57 a.m. (2017-12-21 10:57:52 UTC) #3
hub
On 2017/12/21 10:57:52, Felix Dahlke wrote: > 1) I don't think switching build systems should ...
Jan. 2, 2018, 12:46 p.m. (2018-01-02 12:46:22 UTC) #4
hub
Filed https://issues.adblockplus.org/ticket/6226
Jan. 2, 2018, 2:08 p.m. (2018-01-02 14:08:17 UTC) #5
hub
I need to fix a few issues for build android, but this should work. I ...
March 27, 2018, 8:56 p.m. (2018-03-27 20:56:58 UTC) #6
hub
This is currently in a good state for feedback / review. I was wondering if ...
April 3, 2018, 3:04 p.m. (2018-04-03 15:04:11 UTC) #7
hub
This require to be rebase and fixed for the new things in the build system, ...
June 20, 2018, 12:58 a.m. (2018-06-20 00:58:44 UTC) #8
sergei
On 2018/06/20 00:58:44, hub wrote: > This require to be rebase and fixed for the ...
June 20, 2018, 3:18 p.m. (2018-06-20 15:18:21 UTC) #9
sergei
> [almost DONE] Needs to ensure it builds with Windows I would add that it ...
June 20, 2018, 3:20 p.m. (2018-06-20 15:20:06 UTC) #10
sergei
since building of V8 is not a part of libabp, anything related to it can ...
June 20, 2018, 3:21 p.m. (2018-06-20 15:21:25 UTC) #11
hub
On 2018/06/20 15:20:06, sergei wrote: > > [almost DONE] Needs to ensure it builds with ...
June 20, 2018, 3:44 p.m. (2018-06-20 15:44:16 UTC) #12
hub
Aug. 7, 2018, 5:38 p.m. (2018-08-07 17:38:55 UTC) #13

Powered by Google App Engine
This is Rietveld