Issue 5607 - Namespace content styles in website-defaults

scss/_content.scss

Index: scss/_content.scss
===================================================================
--- a/scss/_content.scss
+++ b/scss/_content.scss
@@ -19,180 +19,195 @@
 /*******************************************************************************
  * Content styles
  *******************************************************************************
  * 1. Document
  * 2. Headings
  * 3. Body content
  ******************************************************************************/
 
-/* Document
- ******************************************************************************/
-
-p,
-ol,
-ul,
-dl,
-pre,
-blockquote
-{
-  /* Set consistent margins (opinionated) */
-  margin: 1em 0em;
-}
-
-/* Headings
- ******************************************************************************/
-
-h1,
-h2,
-h3,
-h4,
-h5,
-h6
-{
-  /* Margin on top **only** (opinionated) */
-  margin: 2em 0em 0.5em 0em;
-}
-
-h1
-{
-  font-size: 2em;
-}
-
-h2
-{
-  font-size: 1.5em;
-}
-
-h3
+.content

[ire, 2017/09/07 12:08:23]

I added this to all the styles here. There are a couple that may not only apply
to .content though, see comments below

[juliandoucette, 2017/09/08 15:43:53]

Acknowledged.

 {
-  font-size: 1.25em;
-}
+
+  /* Document
+  ******************************************************************************/
 
-h4
-{
-  font-size: 1em;
-}
+  p,
+  ol,
+  ul,
+  dl,
+  pre,
+  blockquote
+  {
+    /* Set consistent margins (opinionated) */
+    margin: 1em 0em;
+  }
+
+  /* Headings
+  ******************************************************************************/
 
-h5
-{
-  font-size: 0.8em;
-}
+  h1,
+  h2,
+  h3,
+  h4,
+  h5,
+  h6
+  {
+    /* Margin on top **only** (opinionated) */
+    margin: 2em 0em 0.5em 0em;
+  }
 
-h6
-{
-  font-size: 0.7em;
-}
+  h1
+  {
+    font-size: 2em;
+  }
 
-/* Body content
- ******************************************************************************/
+  h2
+  {
+    font-size: 1.5em;
+  }
 
-abbr
-{
-  text-decoration: underline;
-  cursor: help;
-}
+  h3
+  {
+    font-size: 1.25em;
+  }
+
+  h4
+  {
+    font-size: 1em;
+  }
 
-b,
-strong
-{
-  font-weight: $bold-weight;
-}
+  h5
+  {
+    font-size: 0.8em;
+  }
+
+  h6
+  {
+    font-size: 0.7em;
+  }
+
+  /* Body content
+  ******************************************************************************/
 
-small
-{
-  font-size: $small-font;
-}
+  abbr
+  {
+    text-decoration: underline;
+    cursor: help;
+  }
+
+  b,
+  strong

[ire, 2017/09/07 12:08:23]

Should this be global?

[juliandoucette, 2017/09/08 15:43:53]

Yes, and...

NIT: I think that we should consider the relative value "bolder" if it's
supported alright across browsers because it's possible to have a <strong> in an
already bold element. Of course, we can/should address this in a separate issue.

[ire, 2017/09/11 11:12:02]

Acknowledged.

[ire, 2017/09/11 11:29:16]

See https://issues.adblockplus.org/ticket/5651

[juliandoucette, 2017/09/11 15:54:34]

Acknowledged.

+  {
+    font-weight: $bold-weight;
+  }
 
-sup
-{
-  position: relative;
-  font-size: 75%;
-  vertical-align: super;
-}
+  small
+  {
+    font-size: $small-font;

[juliandoucette, 2017/09/08 15:43:53]

NIT: I think that we should consider a relative value (e.g. 80%) that is equal
to $small-font. Of course, we can/should address this in a separate issue.

[ire, 2017/09/11 11:12:02]

Acknowledged.

+  }
+
+  sup
+  {
+    position: relative;
+    font-size: 75%;
+    vertical-align: super;
+  }
 
-a,
-a:visited
-{
-  color: $accent;
-  /* Remove the gray background on active links in IE 10. */
-  background-color: transparent;
-  text-decoration: none;
-  /* Set default pointer regardless of href (opinionated) */
-  cursor: pointer;
-}
+  a,
+  a:visited

[ire, 2017/09/07 12:08:23]

This should probably be global

[juliandoucette, 2017/09/08 15:43:53]

Regarding what should and should not be global. Perhaps there is a simple rule
here? e.g. all inline content elements should be global and block content
elements should be namespaced. Can you think of any obvious exceptions? (I
haven't yet.)

[ire, 2017/09/11 11:12:02]

This is a good rule. I can't think of any exceptions either.

+  {
+    color: $accent;
+    /* Remove the gray background on active links in IE 10. */
+    background-color: transparent;
+    text-decoration: none;
+    /* Set default pointer regardless of href (opinionated) */
+    cursor: pointer;
+  }
+
+  a:hover,
+  a:active,
+  a:focus
+  {
+    text-decoration: underline;
+  }
 
-a:hover,
-a:active,
-a:focus
-{
-  text-decoration: underline;
-}
+  img

[ire, 2017/09/07 12:08:23]

This should probably be global

[juliandoucette, 2017/09/08 15:43:53]

Acknowledged.

+  {
+    /* Make fixed width images responsive */
+    max-width: 100%;
+    /* Remove the border on images inside links in IE 10-. */
+    border-style: none;
+  }
+
+  hr
+  {
+    border: 1px solid $secondary-light;
+  }
+
+  blockquote
+  {
+    padding-left: 1em;
+    border-left: 5px solid $secondary;
+  }
+
+  [dir="rtl"] blockquote
+  {
+    padding-right: 1em;
+    padding-left: 0em;
+    border-right: 5px solid $secondary-light;
+    border-left: 0px;
+  }
 
-img
-{
-  /* Make fixed width images responsive */
-  max-width: 100%;
-  /* Remove the border on images inside links in IE 10-. */
-  border-style: none;
-}
+  ol,
+  ul
+  {
+    padding-left: 1.5em;
+  }
 
-hr
-{
-  border: 1px solid $secondary-light;
-}
+  [dir="rtl"] ol,
+  [dir="rtl"] ul
+  {
+    padding-right: 2em;
+    padding-left: 0em;
+  }
+
+  ol
+  {
+    list-style: decimal;
+  }
+
+  ul
+  {
+    list-style: disc;
+  }
 
-blockquote
-{
-  padding-left: 1em;
-  border-left: 5px solid $secondary;
-}
+  li
+  {
+    margin: 0.25em 0em;
+  }
+
+  ol ol,
+  ul ul,
+  ol ul,
+  ul ol
+  {
+    /* prevent double spacing lists */
+    margin: 0em;
+  }
 
-[dir="rtl"] blockquote
-{
-  padding-right: 1em;
-  padding-left: 0em;
-  border-right: 5px solid $secondary-light;
-  border-left: 0px;
+  ol ol
+  {
+    list-style-type: lower-alpha;
+  }
+
+  dt
+  {
+    /* undo browser default (opinionated)*/
+    font-weight: $bold-weight;
+  }
+
+  dd
+  {
+    margin: 0.25em 0em 1em 0em;
+  }
+
 }
-
-ol,
-ul
-{
-  padding-left: 1.5em;
-}
-
-[dir="rtl"] ol,
-[dir="rtl"] ul
-{
-  padding-right: 2em;
-  padding-left: 0em;
-}
-
-li
-{
-  margin: 0.25em 0em;
-}
-
-ol ol,
-ul ul,
-ol ul,
-ul ol
-{
-  /* prevent double spacing lists */
-  margin: 0em;
-}
-
-ol ol
-{
-  list-style-type: lower-alpha;
-}
-
-dt
-{
-  /* undo browser default (opinionated)*/
-  font-weight: $bold-weight;
-}
-
-dd
-{
-  margin: 0.25em 0em 1em 0em;
-}