Issue 5642 - Fix Windows Store devbuild upload routine

sitescripts/extensions/bin/createNightlies.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 602 matching lines @@
         request = urllib2.Request(submissions_path, '', headers)
         request.get_method = lambda: 'POST'
         with contextlib.closing(opener.open(request)) as response:
             submission = json.load(response)
 
         submission_id = submission['id']
         file_upload_url = submission['fileUploadUrl']
 
         # Update submission
         submission['applicationPackages'][0]['fileStatus'] = 'PendingDelete'
-        submission['applicationPackages'].append(
-            {

[Sebastian Noack, 2017/09/08 17:30:31]

FWIW, it would be OK to put the parenthesis an braces on one line like this:

submission['applicationPackages'].append({
    ...
})

-                'fileStatus': 'PendingUpload',
-                'fileName': os.path.basename(self.path)

[tlucas, 2017/09/08 11:26:38]

nit: Please add a comma to the last line of a multi line definition, that way
only one line has to be edited when adding additional items.

-            }
-        )
+        submission['applicationPackages'].append({
+            'fileStatus': 'PendingUpload',
+            'fileName': os.path.basename(self.path),
+        })
 
         new_submission_path = '{}/{}'.format(submissions_path,
                                              submission_id)
         new_submission = json.dumps(submission)
 
         request = urllib2.Request(new_submission_path, new_submission, headers)
         request.get_method = lambda: 'PUT'
         opener.open(request).close()
 
         self.upload_appx_file_to_windows_store(file_upload_url)
@@ skipping 96 matching lines @@
         except Exception as ex:
             logging.error('The build for %s failed:', repo)
             logging.exception(ex)
 
     file = open(nightlyConfigFile, 'wb')
     nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
     main()