Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: sitescripts/extensions/bin/createNightlies.py

Issue 29538644: Issue 5642 - Fix Windows Store devbuild upload routine (Closed)
Left Patch Set: Cosmetic fix Created Sept. 8, 2017, 7:16 p.m.
Right Patch Set: Fix indentation Created Sept. 8, 2017, 8:10 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of the Adblock Plus web scripts, 1 # This file is part of the Adblock Plus web scripts,
2 # Copyright (C) 2006-present eyeo GmbH 2 # Copyright (C) 2006-present eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
614 request.get_method = lambda: 'POST' 614 request.get_method = lambda: 'POST'
615 with contextlib.closing(opener.open(request)) as response: 615 with contextlib.closing(opener.open(request)) as response:
616 submission = json.load(response) 616 submission = json.load(response)
617 617
618 submission_id = submission['id'] 618 submission_id = submission['id']
619 file_upload_url = submission['fileUploadUrl'] 619 file_upload_url = submission['fileUploadUrl']
620 620
621 # Update submission 621 # Update submission
622 submission['applicationPackages'][0]['fileStatus'] = 'PendingDelete' 622 submission['applicationPackages'][0]['fileStatus'] = 'PendingDelete'
623 submission['applicationPackages'].append({ 623 submission['applicationPackages'].append({
624 'fileStatus': 'PendingUpload', 624 'fileStatus': 'PendingUpload',
Sebastian Noack 2017/09/08 20:07:18 Nit: It should be just 4, not 8 spaces, per indent
625 'fileName': os.path.basename(self.path), 625 'fileName': os.path.basename(self.path),
626 }) 626 })
627 627
628 new_submission_path = '{}/{}'.format(submissions_path, 628 new_submission_path = '{}/{}'.format(submissions_path,
629 submission_id) 629 submission_id)
630 new_submission = json.dumps(submission) 630 new_submission = json.dumps(submission)
631 631
632 request = urllib2.Request(new_submission_path, new_submission, headers) 632 request = urllib2.Request(new_submission_path, new_submission, headers)
633 request.get_method = lambda: 'PUT' 633 request.get_method = lambda: 'PUT'
634 opener.open(request).close() 634 opener.open(request).close()
635 635
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 except Exception as ex: 733 except Exception as ex:
734 logging.error('The build for %s failed:', repo) 734 logging.error('The build for %s failed:', repo)
735 logging.exception(ex) 735 logging.exception(ex)
736 736
737 file = open(nightlyConfigFile, 'wb') 737 file = open(nightlyConfigFile, 'wb')
738 nightlyConfig.write(file) 738 nightlyConfig.write(file)
739 739
740 740
741 if __name__ == '__main__': 741 if __name__ == '__main__':
742 main() 742 main()
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld