Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(654)

Issue 29539660: Issue 5644 - Add --binary to git diff options (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Vasily Kuznetsov
Modified:
2 years, 8 months ago
Visibility:
Public.

Description

Add --binary to git diff options repository: https://hg.adblockplus.org/rietveld/ base revision: 5d4e635b14e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M upload.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
Vasily Kuznetsov
This is a change to `upload.py` script that makes it work more consistently with Git ...
2 years, 9 months ago (2017-09-08 16:49:01 UTC) #1
mathias
I wonder why the `git show` commands (e.g. within `GetFileContent()` and `GetBaseFile()`) would not need ...
2 years, 9 months ago (2017-09-08 19:01:42 UTC) #2
Vasily Kuznetsov
On 2017/09/08 19:01:42, mathias wrote: > I wonder why the `git show` commands (e.g. within ...
2 years, 9 months ago (2017-09-08 20:24:50 UTC) #3
mathias
On 2017/09/08 20:24:50, Vasily Kuznetsov wrote: > On 2017/09/08 19:01:42, mathias wrote: > > I ...
2 years, 9 months ago (2017-09-08 20:48:32 UTC) #4
Vasily Kuznetsov
On 2017/09/08 20:48:32, mathias wrote: > On 2017/09/08 20:24:50, Vasily Kuznetsov wrote: > > On ...
2 years, 9 months ago (2017-09-08 23:02:14 UTC) #5
mathias
LGTM.
2 years, 9 months ago (2017-09-08 23:10:24 UTC) #6
tlucas
2 years, 8 months ago (2017-09-11 08:27:21 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5