upload.py - Issue 29539660: Issue 5644 - Add --binary to git diff options

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: upload.py

Issue 29539660: Issue 5644 - Add --binary to git diff options (Closed)

Patch Set: Created Sept. 8, 2017, 10:17 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: upload.py

===================================================================

--- a/upload.py

+++ b/upload.py

@@ -1612,16 +1612,17 @@

del env["GIT_EXTERNAL_DIFF"]

# -M/-C will not print the diff for the deleted file when a file is renamed.

# This is confusing because the original file will not be shown on the

# review when a file is renamed. So, get a diff with ONLY deletes, then

# append a diff (with rename detection), without deletes.

cmd = [

"git", "diff", "--no-color", "--no-ext-diff", "--full-index",

"--ignore-submodules", "--src-prefix=a/", "--dst-prefix=b/",

+ "--binary",

]

diff = RunShell(

cmd + ["--no-renames", "--diff-filter=D"] + extra_args,

env=env, silent_ok=True)

assert 0 <= self.options.git_similarity <= 100

if self.options.git_find_copies:

similarity_options = ["-l100000", "-C%d%%" % self.options.git_similarity]

if self.options.git_find_copies_harder:

« no previous file with comments | « no previous file | no next file » | no next file with comments »