Issue 5646 - Added Scottish flag

Issue 5646 - Added Scottish flag

[juliandoucette, 2017-09-08 14:58:58]

LGTM

[wspee, 2017-09-08 15:40:52]

On 2017/09/08 14:58:58, juliandoucette wrote:
> LGTM

As discussed I have update the review to also rename all existing flags.

[juliandoucette, 2017-09-08 17:14:28]

NIT:
- bosnia-and-herzegovina -> bosnia-herzegovina (opinionated) 
- reat-britain -> united-kingdom or uk (opinionated + their flags are actually
different, you are referring to the UK flag)
- united-states-of-america -> united-states or us or usa (opinionated)

[I don't like long names, I think that the US & UK could be exceptions because
they are so widely known by their initials]

[juliandoucette, 2017-09-08 17:16:15]

NIT:
- why is Vietnam hyphenated?

[juliandoucette, 2017-09-08 17:22:47]

Note:
- I don't know what I'm talking about regarding UK flags. I based my last
comment off of a 2 second google search. Please double check.

[ire, 2017-09-11 07:49:35]

Thanks Winsley!

Could you please also update the
[README](https://hg.adblockplus.org/web.eyeo.com/file/tip/static/images/flags/README.txt)
on how to add new flags to reflect this change.

Regarding names, I agree with Julian about not liking long names, but I think in
this case it's probably clearer if we just stick to the full names of the
countries, so there's no confusion about which to use when. I'm happy either way
though, so up to Winsley what he decides to go with.

[wspee, 2017-09-11 08:27:41]

On 2017/09/08 17:14:28, juliandoucette wrote:
> NIT:
> - bosnia-and-herzegovina -> bosnia-herzegovina (opinionated) 
> - reat-britain -> united-kingdom or uk (opinionated + their flags are actually
> different, you are referring to the UK flag)
> - united-states-of-america -> united-states or us or usa (opinionated)
> 
> [I don't like long names, I think that the US & UK could be exceptions because
> they are so widely known by their initials]

I agree about the long names. It seems Great Britain (technically United Kingdom
of Great Britain and Northern Ireland) and United States (technically United
States of America) are so widely used that they are practically synonyms and
it's fine to use without confusion.

(Also the flag/name for Great Britain seems to be fine, see
https://en.wikipedia.org/wiki/United_Kingdom)

[wspee, 2017-09-11 08:28:05]

On 2017/09/08 17:16:15, juliandoucette wrote:
> NIT:
> - why is Vietnam hyphenated?

Done

[wspee, 2017-09-11 08:28:28]

On 2017/09/11 07:49:35, ire wrote:
> Thanks Winsley!
> 
> Could you please also update the
>
[README](https://hg.adblockplus.org/web.eyeo.com/file/tip/static/images/flags/README.txt)
> on how to add new flags to reflect this change.

Good point, thanks. Done.

[ire, 2017-09-11 09:43:47]

On 2017/09/11 08:28:28, wspee wrote:
> On 2017/09/11 07:49:35, ire wrote:
> > Thanks Winsley!
> > 
> > Could you please also update the
> >
>
[README](https://hg.adblockplus.org/web.eyeo.com/file/tip/static/images/flags/README.txt)
> > on how to add new flags to reflect this change.
> 
> Good point, thanks. Done.

Thanks. LGTM

[juliandoucette, 2017-09-11 14:36:20]

On 2017/09/11 08:27:41, wspee wrote:
> I agree about the long names. It seems Great Britain (technically United
Kingdom
> of Great Britain and Northern Ireland) and United States (technically United
> States of America) are so widely used that they are practically synonyms and
> it's fine to use without confusion.
> 
> (Also the flag/name for Great Britain seems to be fine, see
> https://en.wikipedia.org/wiki/United_Kingdom)

It seems obvious to me that we should use "united-kingdom" then (since the
United Kingdom technically includes the Island of Great Britain). Am I missing
something?

[wspee, 2017-09-11 14:45:19]

On 2017/09/11 14:36:20, juliandoucette wrote:
> On 2017/09/11 08:27:41, wspee wrote:
> > I agree about the long names. It seems Great Britain (technically United
> Kingdom
> > of Great Britain and Northern Ireland) and United States (technically United
> > States of America) are so widely used that they are practically synonyms and
> > it's fine to use without confusion.
> > 
> > (Also the flag/name for Great Britain seems to be fine, see
> > https://en.wikipedia.org/wiki/United_Kingdom)
> 
> It seems obvious to me that we should use "united-kingdom" then (since the
> United Kingdom technically includes the Island of Great Britain). Am I missing
> something?

Both are commonly used according to wikipedia but I can see the argument why
United Kingdom is technically more correct. Updated the review accordingly.

[juliandoucette, 2017-09-11 14:54:13]

LGTM

[juliandoucette, 2017-09-12 13:23:39]

Pushed. Please close.