Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29539827: Noissue - Added configurable breakpoints and phablet widths to grid (Closed)

Created:
Sept. 8, 2017, 4:17 p.m. by juliandoucette
Modified:
Sept. 11, 2017, 4:02 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Noissue - Added configurable breakpoints and phablet widths to grid

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed mobile to phone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M scss/_grid.scss View 2 chunks +10 lines, -7 lines 0 comments Download
M scss/_variables.scss View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
juliandoucette
Sept. 8, 2017, 4:17 p.m. (2017-09-08 16:17:50 UTC) #1
juliandoucette
Talking to myself. https://codereview.adblockplus.org/29539827/diff/29539828/scss/_variables.scss File scss/_variables.scss (right): https://codereview.adblockplus.org/29539827/diff/29539828/scss/_variables.scss#newcode91 scss/_variables.scss:91: $mobile-width: auto !default; Make up your ...
Sept. 8, 2017, 5:05 p.m. (2017-09-08 17:05:46 UTC) #2
ire
Sept. 11, 2017, 7:55 a.m. (2017-09-11 07:55:18 UTC) #3
LGTM

https://codereview.adblockplus.org/29539827/diff/29539828/scss/_variables.scss
File scss/_variables.scss (right):

https://codereview.adblockplus.org/29539827/diff/29539828/scss/_variables.scs...
scss/_variables.scss:91: $mobile-width: auto !default;
On 2017/09/08 17:05:46, juliandoucette wrote:
> Make up your mind Julian "phone" or "mobile" IDK :D

Haha. I think $phone may be more accurate, since phablets/tablets are
technically "mobile"

Powered by Google App Engine
This is Rietveld