Issue 5506 - Make the notification test work.

test/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <iostream>
-#include <AdblockPlus/DefaultLogSystem.h>
 #include "BaseJsTest.h"
-#include "../src/DefaultTimer.h"
 
 using namespace AdblockPlus;
 
 namespace
 {
   class NotificationTest : public BaseJsTest
   {
   protected:
     void SetUp()
     {
@@ skipping 49 matching lines @@
       serverResponse.responseText = responseText;
       getCallback(serverResponse);
     }
   };
 
   // To run this test one needs to set INITIAL_DELAY to about 2000 msec
   // in notification.js.
   class NotificationMockWebRequestTest : public BaseJsTest
   {
   protected:
-    AdblockPlus::Sync sync;
+    bool isNotificationCallbackCalled;
+    DelayedTimer::SharedTasks timerTasks;
     void SetUp()
     {
+      isNotificationCallbackCalled = false;
       const char* responseJsonText = "{"
         "\"notifications\": [{"
           "\"id\": \"some id\","
           "\"type\": \"information\","
           "\"message\": {"
              "\"en-US\": \"message\""
           "},"
           "\"title\": \"Title\""
         "}]"
         "}";
 
-      AdblockPlus::Platform::CreationParameters platformParams;
-      platformParams.logSystem.reset(new AdblockPlus::DefaultLogSystem());
-      platformParams.timer.reset(new AdblockPlus::DefaultTimer());

[sergei, 2017/09/11 21:22:38]

I would recommend to not use threads here and wait so long. There could be a
mock timer and we could manually call a corresponding timer callback from the
test body in order to simulate it. We could basically call all timer callbacks
with 1 minute timeout, it seems the easiest way, though hacky.

-      platformParams.fileSystem.reset(new LazyFileSystem());
+      LazyFileSystem* fileSystem;
+      ThrowingPlatformCreationParameters platformParams;
+      platformParams.timer = DelayedTimer::New(timerTasks);
+      platformParams.fileSystem.reset(fileSystem = new LazyFileSystem());
       platformParams.webRequest.reset(new MockWebRequest(responseJsonText));
       platform.reset(new Platform(std::move(platformParams)));
 
+      CreateFilterEngine(*fileSystem, *platform);
       auto& filterEngine = platform->GetFilterEngine();
       filterEngine.SetShowNotificationCallback(
         [this](Notification&& notification) {
-          sync.Set();
+          isNotificationCallbackCalled = true;
           EXPECT_EQ(NotificationType::NOTIFICATION_TYPE_INFORMATION, notification.GetType());
           EXPECT_EQ("Title", notification.GetTexts().title);
           EXPECT_EQ("message", notification.GetTexts().message);
           notification.MarkAsShown();
         });
     }
   };
 }
 
 TEST_F(NotificationTest, NoNotifications)
 {
   EXPECT_FALSE(PeekNotification());
 }
 
 TEST_F(NotificationMockWebRequestTest, SingleNotification)
 {
   auto& filterEngine = platform->GetFilterEngine();
-  filterEngine.ShowNextNotification();
-  EXPECT_TRUE(sync.WaitFor(std::chrono::seconds(70)));
+  auto ii = timerTasks->begin();
+  while(!isNotificationCallbackCalled && ii != timerTasks->end()) {
+    ii->callback();
+    ii = timerTasks->erase(ii);
+    filterEngine.ShowNextNotification();
+  }
+  EXPECT_TRUE(isNotificationCallbackCalled);
 }
 
 TEST_F(NotificationTest, AddNotification)
 {
   AddNotification("{"
       "type: 'critical',"
       "title: 'testTitle',"
       "message: 'testMessage',"
     "}");
   auto notification = PeekNotification();
@@ skipping 47 matching lines @@
 TEST_F(NotificationTest, Links)
 {
   AddNotification("{ id: 'id', links: ['link1', 'link2'] }");
   auto notification = PeekNotification();
   ASSERT_TRUE(notification);
   std::vector<std::string> notificationLinks = notification->GetLinks();
   ASSERT_EQ(2u, notificationLinks.size());
   EXPECT_EQ("link1", notificationLinks[0]);
   EXPECT_EQ("link2", notificationLinks[1]);
 }