Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerEdge.py

Issue 29540555: Issue 5649 - Include full version number in AppxManifest.xml (Closed)
Patch Set: Created Sept. 11, 2017, 1:51 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | templates/edge/AppxManifest.xml.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerEdge.py
===================================================================
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -69,20 +69,17 @@
path = '{}/_locales/{}/messages.json'.format(EXTENSION_DIR, locale)
return json.loads(files[path])
-
Vasily Kuznetsov 2017/09/11 09:49:54 Removing these empty lines seems unrelated and it'
Sebastian Noack 2017/09/11 15:43:10 Sorry, this change was not intended. I added those
def pad_version(version):
"""Make sure version number has 4 groups of digits."""
groups = (version.split('.') + ['0', '0', '0'])[:4]
return '.'.join(groups)
-
def create_appx_manifest(params, files, release_build=False):
"""Create AppxManifest.xml."""
params = dict(params)
metadata = params['metadata']
w = params['windows_version'] = {}
w['min'], w['max'] = metadata.get('compat', 'windows').split('/')
- params.update(metadata.items('general'))
params['version'] = pad_version(params['version'])
metadata_suffix = 'release' if release_build else 'devbuild'
« no previous file with comments | « no previous file | templates/edge/AppxManifest.xml.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld