Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: stylelint-config-eyeo/index.js

Issue 29541680: Issue 5109 - Create stylelintrc for websites and ui modules (Closed) Base URL: https://hg.adblockplus.org/codingtools
Left Patch Set: Remove comments with no rules, allow no-empty line after-comment and inside-block Created Oct. 30, 2017, 8:29 a.m.
Right Patch Set: Fix trailing whitespace errors Created Dec. 14, 2017, 10:38 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « stylelint-config-eyeo/README.md ('k') | stylelint-config-eyeo/package.json » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
juliandoucette 2017/10/31 14:22:45 This isn't part of adblockplus.org
ire 2017/11/01 11:06:09 This is the same licence header from eslint-config
juliandoucette 2017/11/01 13:14:26 @kzar do you consider this and eslint-config-eyeo
kzar 2017/11/03 13:38:38 I would check with legal, it's quite possible I ju
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 module.exports = { 20 module.exports = {
21 extends: "stylelint-config-recommended", 21 extends: "stylelint-config-recommended",
22 rules: { 22 rules: {
23 // Opening braces go on their own line 23 // Opening braces go on their own line
24 "block-opening-brace-newline-before": "always-multi-line",
25 "block-opening-brace-newline-after": "always-multi-line",
26 "block-closing-brace-newline-before": "always-multi-line",
27 "block-closing-brace-newline-after": "always",
24 "block-closing-brace-empty-line-before": "never", 28 "block-closing-brace-empty-line-before": "never",
25 "block-closing-brace-newline-after": "always",
26 "block-closing-brace-newline-before": "always-multi-line",
27 "block-opening-brace-newline-after": "always-multi-line",
28 "block-opening-brace-newline-before": "always-multi-line",
29 29
30 // Use a space between the last selector and the declaration block 30 // Use a space between the last selector and the declaration block
31 "block-opening-brace-space-before": "always-single-line",
31 "block-closing-brace-space-after": "always-single-line", 32 "block-closing-brace-space-after": "always-single-line",
32 "block-closing-brace-space-before": "always-single-line",
33 "block-opening-brace-space-after": "always-single-line",
juliandoucette 2017/10/31 14:22:45 Suggest: Open before close? (very opinionated - ig
ire 2017/11/01 11:06:09 I agree. And I also think: opening before > openin
ire 2017/11/01 11:06:10 Done.
34 "block-opening-brace-space-before": "always-single-line",
35 33
36 // Use a space after a property name’s colon. 34 // Use a space after a property name’s colon
37 "declaration-colon-space-after": "always", 35 "declaration-colon-space-after": "always",
38 36
39 // Separate selectors and declarations by new lines. 37 // Selectors and declarations should be on their own line
40 "selector-list-comma-newline-after": "always", 38 "selector-list-comma-newline-after": "always",
41 "declaration-block-semicolon-newline-after": "always-multi-line", 39 "declaration-block-semicolon-newline-after": "always-multi-line",
42 40
43 // Separate rules by new lines. 41 // Separate rules by an empty line
44 "rule-empty-line-before": ["always", { 42 "rule-empty-line-before": ["always", {
45 "ignore": ["after-comment", "inside-block"] 43 "ignore": ["after-comment", "first-nested"]
46 }], 44 }],
47 45
48 // Use double over single quotation marks 46 // Use double over single quotation marks
49 "string-quotes": "double", 47 "string-quotes": "double",
50 48
51 // CSS color values should be specified in hexadecimal where possible 49 // CSS color values should be specified in hexadecimal where possible
52 "color-named": "never", 50 "color-named": "never",
53 51
54 // Use 3 character hexadecimal notation where possible. 52 // Use short hexadecimal notation where possible
55 "color-hex-length": "short", 53 "color-hex-length": "short",
56 54
57 // Don't omit the optional leading 0 for decimal numbers 55 // Don't omit the optional leading 0 for decimal numbers
58 "number-leading-zero": "always", 56 "number-leading-zero": "always",
59 "number-no-trailing-zeros": true, 57 "number-no-trailing-zeros": true,
60 58
61 // Two spaces per logic level 59 // Two spaces per logic level
62 "indentation": 2, 60 "indentation": 2,
63 61
64 // Line length should be 80 characters or less 62 // Line length should be 80 characters or less
65 "max-line-length": 80, 63 "max-line-length": 80,
66 64
67 // Avoid qualifying ID and class names with type selectors. 65 // Avoid qualifying ID and class names with type selectors
68 "selector-no-qualifying-type": [true, { 66 "selector-no-qualifying-type": [true, {
69 "ignore": ["attribute"] 67 "ignore": ["attribute"]
70 }] 68 }]
71 } 69 }
72 }; 70 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld