Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/js/index.js

Issue 29541876: Noissue - Always show "Install" button for Microsoft Edge (Closed)
Patch Set: Created Sept. 11, 2017, 5:12 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « includes/index.tmpl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 (function() 1 (function()
2 { 2 {
3 var visibleTab; 3 var visibleTab;
4 var container; 4 var container;
5 5
6 window.toggleMore = function() 6 window.toggleMore = function()
7 { 7 {
8 if (container.className == "hidden") 8 if (container.className == "hidden")
9 container.className = visibleTab || getDefaultTab(); 9 container.className = visibleTab || getDefaultTab();
10 else 10 else
(...skipping 21 matching lines...) Expand all
32 checkEdgeSupport(); 32 checkEdgeSupport();
33 } 33 }
34 34
35 function checkEdgeSupport() 35 function checkEdgeSupport()
36 { 36 {
37 if (!window.navigator.userAgent) 37 if (!window.navigator.userAgent)
38 return; 38 return;
39 39
40 var content = document.getElementById("content"); 40 var content = document.getElementById("content");
41 var match = window.navigator.userAgent.match(/Edge\/\d+\.(\d+)/); 41 var match = window.navigator.userAgent.match(/Edge\/\d+\.(\d+)/);
42 if (match && match[1] >= 14361 && content.classList.contains("edge")) 42 if (match && match[1] >= 15063 && content.classList.contains("edge"))
Oleksandr 2017/09/12 00:25:57 It's outside the scope of this change, but I just
Sebastian Noack 2017/09/12 00:58:20 What would users see on XBox and Windows Phone, wh
juliandoucette 2017/09/12 11:47:17 I second Sebastian's question. Can you test this?
Oleksandr 2017/09/12 17:20:08 I am actually fairly confident Windows Store would
43 content.classList.add("edge-supported"); 43 content.classList.add("edge-supported");
44 } 44 }
45 45
46 init(); 46 init();
47 })(); 47 })();
OLDNEW
« no previous file with comments | « includes/index.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld