mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in - Issue 29542628: Issue 3994 - Do not register ABB to Androids AccountManager

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in

Issue 29542628: Issue 3994 - Do not register ABB to Androids AccountManager (Closed)

Left Patch Set: Issue 3994 - Do not register ABB to Androids AccountManager Created Sept. 12, 2017, 1:31 p.m.

Right Patch Set: Added a comment Created Sept. 15, 2017, 8:05 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!-- Do not register ABB to Androids AccountManager. See: https://issues .adblockplus.org/ticket/3994 -->	1 <!-- Removed FxAccountAuthenticatorService from manifest. See https://is sues.adblockplus.org/ticket/3994 -->

2 <!--
diegocarloslima 2017/09/12 14:22:28 Instead of commenting out, we usually remove the c Instead of commenting out, we usually remove the code
3 <service

4 android:exported="true"

5 android:name="org.mozilla.gecko.fxa.authenticator.FxAccountAuthentic atorService" >

6 <intent-filter >

7 <action android:name="android.accounts.AccountAuthenticator" />

8 </intent-filter>

9

10 <meta-data

11 android:name="android.accounts.AccountAuthenticator"

12 android:resource="@xml/fxaccount_authenticator" />

13 </service>

14 -->

15 <service	2 <service

16 android:exported="false"	3 android:exported="false"

17 android:name="org.mozilla.gecko.fxa.receivers.FxAccountDeletedServic e" >	4 android:name="org.mozilla.gecko.fxa.receivers.FxAccountDeletedServic e" >

18 </service>	5 </service>

19	6

20 <service	7 <service

21 android:exported="false"	8 android:exported="false"

22 android:name="org.mozilla.gecko.fxa.sync.FxAccountProfileService" >	9 android:name="org.mozilla.gecko.fxa.sync.FxAccountProfileService" >

23 </service>	10 </service>

24	11

25 <!-- Firefox Sync. -->	12 <!-- Firefox Sync. -->

26 <service	13 <service

27 android:exported="false"	14 android:exported="false"

28 android:name="org.mozilla.gecko.fxa.sync.FxAccountSyncService" >	15 android:name="org.mozilla.gecko.fxa.sync.FxAccountSyncService" >

29 <intent-filter >	16 <intent-filter >

30 <action android:name="android.content.SyncAdapter" />	17 <action android:name="android.content.SyncAdapter" />

31 </intent-filter>	18 </intent-filter>

32	19

33 <meta-data	20 <meta-data

34 android:name="android.content.SyncAdapter"	21 android:name="android.content.SyncAdapter"

35 android:resource="@xml/fxaccount_syncadapter" />	22 android:resource="@xml/fxaccount_syncadapter" />

36 </service>	23 </service>

LEFT	RIGHT