Issue 5666 - Replace 4th component of version in AppxManifest.xml with 0

packagerEdge.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import base64
 import hashlib
 import json
 import mimetypes
 import os
 import zipfile
@@ skipping 52 matching lines @@
     files = [_make_blockmap_entry(n, d) for n, d in files.items()]
     return template.render(files=files).encode('utf-8')
 
 
 def load_translation(files, locale):
     """Load translation strings for locale from files."""
     path = '{}/_locales/{}/messages.json'.format(EXTENSION_DIR, locale)
     return json.loads(files[path])
 
 
-def pad_version(version):
-    """Make sure version number has 4 groups of digits."""
-    groups = (version.split('.') + ['0', '0', '0'])[:4]
-    return '.'.join(groups)
+def fix_version(version):
+    """
+    Prepares a version number for usage in AppxManifest.xml which requires
+    four components with the last component being zero (e.g. 12.34.56.0).

[tlucas, 2017/09/12 21:24:18]

You should use the imperative for docstrings, e.g. "Prepare a version number..."


In case you really need a multi-line docstring, you should also add a one-line
summary and a blank line, just before the multi-line description.

Or you could transform it into a one-liner, e.g.:
    """Prepare a version number to adhere to the required pattern x.x.x.0."""

What do you think about this?

[Sebastian Noack, 2017/09/12 21:35:45]

Done.

+    """
+    components = version.split('.')[:3]
+    components.extend(['0'] * (4 - len(components)))
+    return '.'.join(components)
 
 
 def create_appx_manifest(params, files, release_build=False):
     """Create AppxManifest.xml."""
     params = dict(params)
     metadata = params['metadata']
     w = params['windows_version'] = {}
     w['min'], w['max'] = metadata.get('compat', 'windows').split('/')
-    params['version'] = pad_version(params['version'])
+    params['version'] = fix_version(params['version'])
 
     metadata_suffix = 'release' if release_build else 'devbuild'
     app_extension_id = 'extension_id_' + metadata_suffix
     if metadata.has_option('general', app_extension_id):
         params['app_extension_id'] = metadata.get('general', app_extension_id)
     else:
         params['app_extension_id'] = 'EdgeExtension'
 
     app_id = 'app_id_' + metadata_suffix
     params['app_id'] = metadata.get('general', app_id)
@@ skipping 89 matching lines @@
     if metadata.has_section('appx_assets'):
         for name, path in metadata.items('appx_assets'):
             path = os.path.join(baseDir, path)
             files.read(path, '{}/{}'.format(ASSETS_DIR, name))
 
     files[MANIFEST] = create_appx_manifest(params, files, releaseBuild)
     files[BLOCKMAP] = create_appx_blockmap(files)
     files[CONTENT_TYPES] = create_content_types_map(files.keys() + [BLOCKMAP])
 
     files.zip(outfile, compression=zipfile.ZIP_STORED)