Issue 5666 - Replace 4th component of version in AppxManifest.xml with 0

tests/test_packagerEdge.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import ConfigParser
 import json
 import os
 import shutil
 import xml.etree.ElementTree as ET
 import zipfile
@@ skipping 195 matching lines @@
             [first, attr('Id')],
             '1.0'),
         ('./ns:Applications/ns:Application/ns:Extensions/uap3:Extension/'
             'uap3:AppExtension',
             [first, attr('DisplayName')],
             'Adblock Plus'),
     ]
 
     for release_build, pairs in [(False, devbuild), (True, release)]:
         manifest = ET.fromstring(packagerEdge.create_appx_manifest(
-            {'metadata': metadata},
+            {'metadata': metadata, 'version': '1.2.3.4'},

[Sebastian Noack, 2017/09/12 19:52:33]

The previous change broke this test already, since params['version'] is no
longer overridden with a value from metadata.

[tlucas, 2017/09/12 21:24:18]

Ack, tox succeeds happily now. (I also added "tox" to my review-cheat-sheet)

             files,
             release_build=release_build))
         for expression, modifiers, value in pairs:
             res = reduce(
                 lambda val, func: func(val),
                 modifiers,
                 manifest.findall(expression, namespaces=namespaces))
             assert res == value
 
 
@@ skipping 23 matching lines @@
     assert 'devbuild-marker' not in appx.read('AppxManifest.xml')
     assert appx.read('Assets/logo_44.png') == '44'
     assert appx.read('Extension/icons/abp-44.png') == '44'
 
 
 def test_create_devbuild(tmpdir, srcdir):
     out_file = str(tmpdir.join('abp.appx'))
     packagerEdge.createBuild(str(srcdir), outFile=out_file, releaseBuild=False)
     appx = zipfile.ZipFile(out_file)
     assert 'devbuild-marker' in appx.read('AppxManifest.xml')