Issue 5666 - Replace 4th component of version in AppxManifest.xml with 0

packagerEdge.py

Index: packagerEdge.py
===================================================================
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -70,10 +70,15 @@
     return json.loads(files[path])
 
 
-def pad_version(version):
-    """Make sure version number has 4 groups of digits."""
-    groups = (version.split('.') + ['0', '0', '0'])[:4]
-    return '.'.join(groups)
+def fix_version(version):
+    """Prepare a version number for usage in AppxManifest.xml.
+    

[tlucas, 2017/09/12 21:38:08]

Flake8 fails on this line:
./packagerEdge.py:75:1: W293 blank line contains whitespace

[Sebastian Noack, 2017/09/12 21:41:18]

Argh, sorry, I forgot to run tox/flake8, again. Apparently just changing a
docstring could still cause warnings. Fixed.

+    As required by the Windows Store, the returned version string has
+    four components with the last component being zero (e.g. 12.34.56.0).
+    """
+    components = version.split('.')[:3]
+    components.extend(['0'] * (4 - len(components)))
+    return '.'.join(components)
 
 
 def create_appx_manifest(params, files, release_build=False):
@@ -82,7 +87,7 @@
     metadata = params['metadata']
     w = params['windows_version'] = {}
     w['min'], w['max'] = metadata.get('compat', 'windows').split('/')
-    params['version'] = pad_version(params['version'])
+    params['version'] = fix_version(params['version'])
 
     metadata_suffix = 'release' if release_build else 'devbuild'
     app_extension_id = 'extension_id_' + metadata_suffix