Noissue - fix generation of a new instance creation of a class without subclass differentiator

compiled/bindings/generator.cpp

Index: compiled/bindings/generator.cpp
diff --git a/compiled/bindings/generator.cpp b/compiled/bindings/generator.cpp
index ab6c504625e3f21b96ae6d44ee7336c7dc307722..56e9463329633436bd5bb46be1f92c681a41c649 100644
--- a/compiled/bindings/generator.cpp
+++ b/compiled/bindings/generator.cpp
@@ -257,11 +257,7 @@ namespace bindings_internal
         if (!cls)
           throw std::runtime_error("Function " + call.name + " returns pointer to unknown class");
 
-        auto offset = cls->subclass_differentiator.offset;
-        if (offset == SIZE_MAX)
-          result += "    result = exports." + cls->name + "(result);\n";
-        else
-          result += "    result = exports." + cls->name + ".fromPointer(result);\n";
+        result += "    result = exports." + cls->name + ".fromPointer(result);\n";

[sergei, 2017/09/13 17:09:10]

Another option here could be to keep the if and for the branch without the
differentiator put ("new " added):
`result += "    result = new exports." + cls->name + "(result);\n";`
and remove the generation of implementation of fromPointer for such classes.
However, I think it can be convenient for debugging and maybe even for some
future changes to call constructors only from "fromPointer".
What is your opinion?

[Wladimir Palant, 2017/09/19 08:51:48]

Trouble is, bindings overhead is very much non-negligible - that's the reason
why I am micro-optimizing here. So I'd rather keep the overhead as low as
possible and not call fromPointer unless necessary. In fact, fromPointer was
inlined here originally and I am still not sure whether turning it into a method
call was the right decision to make.

[sergei, 2017/09/19 09:14:35]

I have uploaded the version without fromPointer for classes without the subclass
differentiator.

 
         result += "  else\n";
         result += "    result = null;\n";