Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29543810: Issue 5118 - Lock the platform interfaces before use (Closed)

Created:
Sept. 13, 2017, 5:21 p.m. by hub
Modified:
Sept. 14, 2017, 1:06 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 5118 - Lock the platform interfaces before use

Patch Set 1 #

Patch Set 2 : Added missing LogSystem #

Total comments: 4

Patch Set 3 : Review feedback #

Total comments: 4

Patch Set 4 : Last details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -135 lines) Patch
M include/AdblockPlus/Platform.h View 1 2 1 chunk +10 lines, -17 lines 0 comments Download
M src/ConsoleJsObject.cpp View 1 2 chunks +10 lines, -4 lines 0 comments Download
M src/FileSystemJsObject.cpp View 6 chunks +123 lines, -94 lines 0 comments Download
M src/JsEngine.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
M src/Platform.cpp View 1 2 3 2 chunks +61 lines, -13 lines 0 comments Download
M src/WebRequestJsObject.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7
hub
Sept. 13, 2017, 5:21 p.m. (2017-09-13 17:21:16 UTC) #1
hub
I forgot LogSystem.
Sept. 13, 2017, 5:34 p.m. (2017-09-13 17:34:48 UTC) #2
sergei
Although I'm not sure about the approach in general, despite it was me, who described ...
Sept. 13, 2017, 7:20 p.m. (2017-09-13 19:20:53 UTC) #3
hub
https://codereview.adblockplus.org/29543810/diff/29543817/include/AdblockPlus/Platform.h File include/AdblockPlus/Platform.h (right): https://codereview.adblockplus.org/29543810/diff/29543817/include/AdblockPlus/Platform.h#newcode129 include/AdblockPlus/Platform.h:129: std::recursive_mutex interfacesMutex; On 2017/09/13 19:20:53, sergei wrote: > What ...
Sept. 13, 2017, 7:50 p.m. (2017-09-13 19:50:50 UTC) #4
sergei
LGTM, however could you please still address this couple of rather decorative things. https://codereview.adblockplus.org/29543810/diff/29543824/src/Platform.cpp File ...
Sept. 13, 2017, 8:06 p.m. (2017-09-13 20:06:38 UTC) #5
hub
https://codereview.adblockplus.org/29543810/diff/29543824/src/Platform.cpp File src/Platform.cpp (right): https://codereview.adblockplus.org/29543810/diff/29543824/src/Platform.cpp#newcode134 src/Platform.cpp:134: virtual void WithTimer(const WithTimerCallback&) override; On 2017/09/13 20:06:37, sergei ...
Sept. 13, 2017, 8:17 p.m. (2017-09-13 20:17:51 UTC) #6
sergei
Sept. 13, 2017, 8:26 p.m. (2017-09-13 20:26:04 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld