Issue 5118 - Lock the platform interfaces before use

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 113 matching lines @@
   if (arguments.Length() < 2)
     throw std::runtime_error("setTimeout requires at least 2 parameters");
 
   if (!arguments[0]->IsFunction())
     throw std::runtime_error("First argument to setTimeout must be a function");
 
   auto jsValueArguments = jsEngine->ConvertArguments(arguments);
   auto timerParamsID = jsEngine->StoreJsValues(jsValueArguments);
 
   std::weak_ptr<JsEngine> weakJsEngine = jsEngine;
-  jsEngine->platform.GetTimer().SetTimer(std::chrono::milliseconds(arguments[1]->IntegerValue()), [weakJsEngine, timerParamsID]
-  {
-    if (auto jsEngine = weakJsEngine.lock())
-      jsEngine->CallTimerTask(timerParamsID);
-  });
+  jsEngine->platform.WithTimer(
+    [arguments, weakJsEngine, timerParamsID](ITimer& timer)
+    {
+      timer.SetTimer(
+        std::chrono::milliseconds(
+          arguments[1]->IntegerValue()), [weakJsEngine, timerParamsID]
+          {
+            if (auto jsEngine = weakJsEngine.lock())
+              jsEngine->CallTimerTask(timerParamsID);
+          });
+    });
 }
 
 void JsEngine::CallTimerTask(const JsWeakValuesID& timerParamsID)
 {
   auto timerParams = TakeJsValues(timerParamsID);
   JsValue callback = std::move(timerParams[0]);
 
   timerParams.erase(timerParams.begin()); // remove callback placeholder
   timerParams.erase(timerParams.begin()); // remove timeout param
   callback.Call(timerParams);
@@ skipping 174 matching lines @@
     list.push_back(JsValue(shared_from_this(), arguments[i]));
   return list;
 }
 
 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               const AdblockPlus::JsValue& value)
 {
   auto global = GetGlobalObject();
   global.SetProperty(name, value);
 }