Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29544668: Noissue - Indicate that the dump field is binary to avoid database warnings about bad UTF-8 encoding (Closed)

Created:
Sept. 14, 2017, 12:01 p.m. by Wladimir Palant
Modified:
Sept. 18, 2017, 8:34 p.m.
Reviewers:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/sitescripts/
Visibility:
Public.

Description

This is not an issue on our legacy server, but the new reports server produces `Invalid utf8 character string` warnings

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sitescripts/reports/utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Sept. 14, 2017, 12:01 p.m. (2017-09-14 12:01:57 UTC) #1
Vasily Kuznetsov
Sept. 18, 2017, 5:43 p.m. (2017-09-18 17:43:45 UTC) #2
On 2017/09/14 12:01:57, Wladimir Palant wrote:

Assuming you've tested it, LGTM.

Powered by Google App Engine
This is Rietveld