Noissue - Adapt check for devtools panel support for Firefox

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 166 matching lines @@
       }
       else
         bidiDir = Utils.readingDirection;
 
       return {locale: Utils.appLocale, bidiDir};
     }
 
     if (message.what == "features")
     {
       return {
-        devToolsPanel: info.platform == "chromium"
+        devToolsPanel: info.platform == "chromium" ||
+                       info.application == "firefox" &&

[Sebastian Noack, 2017/09/14 23:30:49]

I explicitly check for `application == "firefox" here, and not for `platform ==
"gecko"`, since the devtools panel API is not supported on Firefox Mobile.

[Manish Jethani, 2017/09/15 11:37:14]

Acknowledged.

[Manish Jethani, 2017/09/15 11:37:14]

We'll have to use parseInt here since the application version can be something
like "54.0.1", which becomes NaN when converted to a number simply.

I would also use parentheses around the two checks to group them for clarity,
but it's your call.

[Thomas Greiner, 2017/09/15 12:20:04]

Well spotted. Note that we usually use `Services.vc.compare()` to compare
version strings.

[Sebastian Noack, 2017/09/15 16:51:47]

Done.

+                       info.applicationVersion >= 54
       };
     }
 
     return info[message.what];
   });
 
   port.on("app.listen", (message, sender) =>
   {
     getListenerFilters(sender.page).app = message.filter;
   });
@@ skipping 236 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);