Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(255)

Issue 29545663: Issue 5631 - do not show disabled filters in more section (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by saroyanm
Modified:
2 years ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 5631 - do not show disabled filters in more section

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M new-options.html View 1 chunk +1 line, -1 line 0 comments Download
M new-options.js View 5 chunks +9 lines, -8 lines 2 comments Download

Messages

Total messages: 2
saroyanm
Thomas can you please have a look. https://codereview.adblockplus.org/29545663/diff/29545664/new-options.js File new-options.js (right): https://codereview.adblockplus.org/29545663/diff/29545664/new-options.js#newcode355 new-options.js:355: collections.more = ...
2 years ago (2017-09-15 16:38:00 UTC) #1
Thomas Greiner
2 years ago (2017-09-15 17:06:05 UTC) #2
LGTM

https://codereview.adblockplus.org/29545663/diff/29545664/new-options.js
File new-options.js (right):

https://codereview.adblockplus.org/29545663/diff/29545664/new-options.js#newc...
new-options.js:355: collections.more = new Collection([
On 2017/09/15 16:38:00, saroyanm wrote:
> I changed name from custom to more, as custom was ambiguous name and could
have
> been mixed with user's "customFilters".
> Please let me know if you have a better suggestion, I used more to reflect the
> section name in specs.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5