lib/.eslintrc.json - Issue 29545700: Issue 5685 - Pass ESLint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/.eslintrc.json

Issue 29545700: Issue 5685 - Pass ESLint (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Left Patch Set: Created Sept. 15, 2017, 7:38 p.m.

Right Patch Set: Address review comments Created Sept. 18, 2017, 12:42 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "env": {	2 "env": {

3 "commonjs": true	3 "commonjs": true

4 },	4 },

5 "globals": {	5 "globals": {

6 "console": true,	6 "console": true,

7 "setTimeout": true,	7 "setTimeout": true,

8 "_triggerEvent": true,	8 "_triggerEvent": true,

9 "_appInfo": true,	9 "_appInfo": true,

10 "_fileSystem": true,	10 "_fileSystem": true,

11 "_webRequest": true,	11 "_webRequest": true,

12 "_preconfiguredPrefs": true,	12 "_preconfiguredPrefs": true,

13 "onShutdown": true,	13 "onShutdown": true,

14 "extractHostFromURL": true,	14 "extractHostFromURL": true,

15 "isThirdParty": true,	15 "isThirdParty": true,

16 "Cu": true,	16 "Cu": true

17 "Cc": true,

18 "Ci": true
sergei 2017/09/18 07:59:04 Is it necessary to have Cc and Ci for libadblockpl Is it necessary to have Cc and Ci for libadblockplus/lib? It seems they are not used there as. hub 2017/09/18 12:43:04 not in here, indeed. Show quoted text On 2017/09/18 07:59:04, sergei wrote: > Is it necessary to have Cc and Ci for libadblockplus/lib? It seems they are not > used there as. not in here, indeed.
19 }	17 }

20 }	18 }

LEFT	RIGHT