Issue 5685 - Pass ESLint

lib/compat.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 10 matching lines @@
 
 //
 // Module framework stuff
 //
 
 function require(module)
 {
   return require.scopes[module];
 }
 require.scopes = {__proto__: null};
-
-function importAll(module, globalObj)

[sergei, 2017/09/18 07:59:05]

It seems this function is not used, could you just remove it?

[hub, 2017/09/18 12:43:05]

Done.

-{
-  let exports = require(module);
-  for (let key in exports)
-    globalObj[key] = exports[key];
-}
 
 const onShutdown = {
   done: false,
   add() {},
   remove() {}
 };
 
 //
 // XPCOM emulation
 //
 
 // nsIHttpChannel is checked against instanceof.
 class nsIHttpChannel
 {
 }
 
 const Components =
   {
     interfaces:
     {
       nsIHttpChannel,

[hub, 2017/09/15 19:44:00]

This one was a bit of a corner case. eslint style want us to use the "method"
short hand. But this cause to make nsIHttpChannel not be `instanceof
nsIHttpChannel`, causing failures.

So we declare it as an ES6 class.

[sergei, 2017/09/18 07:59:05]

Acknowledged.

       nsITimer: {TYPE_REPEATING_SLACK: 0}
     },
     classes:
     {
       "@mozilla.org/timer;1":
       {
         createInstance()
         {
           return new FakeTimer();
         }
@@ skipping 244 matching lines @@
   send(data)
   {
     if (this.readyState != 1)
       throw new Error(
         "XMLHttpRequest.send() is being called before XMLHttpRequest.open()");
     if (typeof data != "undefined" && data)
       throw new Error("Sending data to server is not supported");
 
     this.readyState = 3;
 
-    let onGetDone = function(result)
+    let onGetDone = result =>
     {
       this.channel.status = result.status;
       this.status = result.responseStatus;
       this.responseText = result.responseText;
       this._responseHeaders = result.responseHeaders;
       this.readyState = 4;
 
       // Notify event listeners
       const NS_OK = 0;
       let eventName = (this.channel.status == NS_OK ? "load" : "error");
       let event = {type: eventName};
 
       if (this["on" + eventName])
         this["on" + eventName].call(this, event);
 
       let list = this["_" + eventName + "Handlers"];
       for (let i = 0; i < list.length; i++)
         list[i].call(this, event);
-    }.bind(this);

[sergei, 2017/09/18 07:59:05]

Could you also turn this function into the arrow function, so this `bind` is not
required.

[hub, 2017/09/18 12:43:05]

Done.

+    };
     // HACK (#5066): the code checking whether the connection is
     // allowed is temporary, the actual check should be in the core
     // when we make a decision whether to update a subscription with
     // current connection or not, thus whether to even construct
     // XMLHttpRequest object or not.
     _isSubscriptionDownloadAllowed(isAllowed =>
     {
       if (!isAllowed)
       {
         onGetDone({
@@ skipping 48 matching lines @@
   // It's a bit hacky, JsEngine interface which is used by FilterEngine does
   // not allow to inject an arbitrary callback, so we use triggerEvent
   // mechanism.
   // Yet one hack (#5039).
   let allowedConnectionType = require("prefs").Prefs.allowed_connection_type;
   if (allowedConnectionType == "")
     allowedConnectionType = null;
   _triggerEvent("_isSubscriptionDownloadAllowed", allowedConnectionType,
                 callback);
 }
-
-// Polyfill Array.prototype.find
-// from https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/find
-// https://tc39.github.io/ecma262/#sec-array.prototype.find
-if (!Array.prototype.find)

[sergei, 2017/09/18 07:59:05]

Is it possible to remove this polyfill? We are already using a newer V8, I would
just remove it.

[hub, 2017/09/18 12:43:05]

Done.

-{
-  Object.defineProperty(Array.prototype, "find",
-    {
-      value(predicate, ...args)
-      {
-        // 1. Let O be ? ToObject(this value).
-        if (this == null)
-        {
-          throw new TypeError("\"this\" is null or not defined");
-        }
-
-        let o = Object(this);
-
-        // 2. Let len be ? ToLength(? Get(O, "length")).
-        let len = o.length >>> 0;
-
-        // 3. If IsCallable(predicate) is false, throw a TypeError exception.
-        if (typeof predicate !== "function")
-        {
-          throw new TypeError("predicate must be a function");
-        }
-
-        // 4. If thisArg was supplied, let T be thisArg; else
-        //    let T be undefined.
-        let thisArg = args[0];
-
-        // 5. Let k be 0.
-        let k = 0;
-
-        // 6. Repeat, while k < len
-        while (k < len)
-        {
-          // a. Let Pk be ! ToString(k).
-          // b. Let kValue be ? Get(O, Pk).
-          // c. Let testResult be ToBoolean(? Call(predicate, T, "kValue,
-          //    k, O")).
-          // d. If testResult is true, return kValue.
-          let kValue = o[k];
-          if (predicate.call(thisArg, kValue, k, o))
-          {
-            return kValue;
-          }
-          // e. Increase k by 1.
-          k++;
-        }
-      }
-    });
-}