pages/index.md - Issue 29548567: Issue 4925 - Create accordion component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: pages/index.md

Issue 29548567: Issue 4925 - Create accordion component for Help Center (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Patch Set: Rebase Created Sept. 19, 2017, 4:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 title=Hello, world	1 title=Hello, world

2	2

	3 <div class="container">

	4

3 # Hello, world	5 # Hello, world

4	6

5 Welcome to the Help Center!	7 Welcome to the Help Center!

	8

	9 <br><br>

	10

	11 <dl class="accordion">

	12 <dt role="heading" aria-level="3" class="accordion-heading">

	13 <button aria-expanded="true" aria-disabled="true" aria-controls="sect1" id=" heading1" class="accordion-toggle-button">

	14 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" \| translate("accordion-toggle-icon", " Image alt text") }}">

	15 Section 1 Title

	16 </button>

	17 </dt>

	18 <dd role="region" aria-labelledby="heading1" id="sect1" class="accordion-body" >

	19 Section 1 Content

	20 </dd>

	21

	22 <dt role="heading" aria-level="3" class="accordion-heading">
	juliandoucette 2017/09/20 14:19:37 I think that the default (non-js) state is aria-ex I think that the default (non-js) state is aria-expanded and aria-disabled. ire 2017/09/25 11:25:17 Yup you're right. My mistake. Also, I realised I d Show quoted text On 2017/09/20 14:19:37, juliandoucette wrote: > I think that the default (non-js) state is aria-expanded and aria-disabled. Yup you're right. My mistake. Also, I realised I don't need aria-disabled anymore because I allowed an expanded section to be closed.
	23 <button aria-expanded="true" aria-disabled="true" aria-controls="sect2" id=" heading2" class="accordion-toggle-button">

	24 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" \| translate("accordion-toggle-icon", " Image alt text") }}">

	25 Section 2 Title

	26 </button>

	27 </dt>

	28 <dd role="region" aria-labelledby="heading2" id="sect2" class="accordion-body" >

	29 Section 2 Content

	30 </dd>

	31

	32 <dt role="heading" aria-level="3" class="accordion-heading">

	33 <button aria-expanded="true" aria-disabled="true" aria-controls="sect3" id=" heading3" class="accordion-toggle-button">

	34 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" \| translate("accordion-toggle-icon", " Image alt text") }}">

	35 Section 3 Title

	36 </button>

	37 </dt>

	38 <dd role="region" aria-labelledby="heading3" id="sect3" class="accordion-body" >

	39 Section 3 Content

	40 </dd>

	41 </dl>

	42

	43 <br><br>

	44

	45 </div>

OLD	NEW

« no previous file with comments | « no previous file | static/img/png/arrow-icon-secondary.png » ('j') | static/js/main.js » ('J')