Delta Between Two Patch Sets: pages/index.md
Issue 29548567:
Issue 4925 - Create accordion component for Help Center (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Rebase
Created Sept. 19, 2017, 4:19 p.m.
Right Patch Set: Refactoring
Created Sept. 28, 2017, 2:48 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
static/img/png/arrow-icon-secondary.png » ('j')
|
static/js/main.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Hello, world | 1 title=Hello, world |
| 2 | 2 |
| 3 <div class="container"> | 3 <div class="container"> |
| 4 | 4 |
| 5 # Hello, world | 5 # Hello, world |
| 6 | 6 |
| 7 Welcome to the Help Center! | 7 Welcome to the Help Center! |
| 8 | 8 |
| 9 <br><br> | 9 <br><br> |
| 10 | 10 |
| 11 <dl class="accordion"> | 11 <dl class="accordion"> |
| 12 <dt role="heading" aria-level="3" class="accordion-heading"> | 12 <dt role="heading" aria-level="3" class="accordion-heading"> |
| 13 <button aria-expanded="true" aria-disabled="true" aria-controls="sect1" id=" heading1" class="accordion-toggle-button"> | 13 <button aria-expanded="true" aria-controls="sect1" id="heading1" class="acco rdion-toggle-button"> |
| 14 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> | 14 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> |
| 15 Section 1 Title | 15 Section 1 Title |
| 16 </button> | 16 </button> |
| 17 </dt> | 17 </dt> |
| 18 <dd role="region" aria-labelledby="heading1" id="sect1" class="accordion-body" > | 18 <dd role="region" aria-labelledby="heading1" id="sect1" class="accordion-body" > |
| 19 Section 1 Content | 19 Section 1 Content |
| 20 </dd> | 20 </dd> |
| 21 | 21 |
| 22 <dt role="heading" aria-level="3" class="accordion-heading"> | 22 <dt role="heading" aria-level="3" class="accordion-heading"> |
|
juliandoucette
2017/09/20 14:19:37
I think that the default (non-js) state is aria-ex
ire
2017/09/25 11:25:17
Yup you're right. My mistake. Also, I realised I d
| |
| 23 <button aria-expanded="true" aria-disabled="true" aria-controls="sect2" id=" heading2" class="accordion-toggle-button"> | 23 <button aria-expanded="true" aria-controls="sect2" id="heading2" class="acco rdion-toggle-button"> |
| 24 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> | 24 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> |
| 25 Section 2 Title | 25 Section 2 Title |
| 26 </button> | 26 </button> |
| 27 </dt> | 27 </dt> |
| 28 <dd role="region" aria-labelledby="heading2" id="sect2" class="accordion-body" > | 28 <dd role="region" aria-labelledby="heading2" id="sect2" class="accordion-body" > |
| 29 Section 2 Content | 29 Section 2 Content |
| 30 </dd> | 30 </dd> |
| 31 | 31 |
| 32 <dt role="heading" aria-level="3" class="accordion-heading"> | 32 <dt role="heading" aria-level="3" class="accordion-heading"> |
| 33 <button aria-expanded="true" aria-disabled="true" aria-controls="sect3" id=" heading3" class="accordion-toggle-button"> | 33 <button aria-expanded="true" aria-controls="sect3" id="heading3" class="acco rdion-toggle-button"> |
| 34 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> | 34 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> |
| 35 Section 3 Title | 35 Section 3 Title |
| 36 </button> | 36 </button> |
| 37 </dt> | 37 </dt> |
| 38 <dd role="region" aria-labelledby="heading3" id="sect3" class="accordion-body" > | 38 <dd role="region" aria-labelledby="heading3" id="sect3" class="accordion-body" > |
| 39 Section 3 Content | 39 Section 3 Content |
| 40 </dd> | 40 </dd> |
| 41 </dl> | 41 </dl> |
| 42 | 42 |
| 43 <br><br> | 43 <br><br> |
| 44 | 44 |
| 45 </div> | 45 </div> |
| LEFT | RIGHT |
« no previous file
|
static/img/png/arrow-icon-secondary.png » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
