Issue 4128, 5138 - Add Parser and Serializer implemented in C++

compiled/String.cpp

Index: compiled/String.cpp
diff --git a/compiled/String.cpp b/compiled/String.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..cdd784d9b19e1c135ec9821f4bcd9a8958b29363
--- /dev/null
+++ b/compiled/String.cpp
@@ -0,0 +1,32 @@
+/*
+* This file is part of Adblock Plus <https://adblockplus.org/>,
+* Copyright (C) 2006-present eyeo GmbH
+*
+* Adblock Plus is free software: you can redistribute it and/or modify
+* it under the terms of the GNU General Public License version 3 as
+* published by the Free Software Foundation.
+*
+* Adblock Plus is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU General Public License for more details.
+*
+* You should have received a copy of the GNU General Public License
+* along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include "String.h"
+
+DependentString TrimSpaces(const String& value)
+{
+  String::size_type start = 0;
+  auto end = value.length();
+  for (; start < end; start++)
+    if (value[start] > u' ')

[Wladimir Palant, 2017/12/21 10:30:36]

That's an unusual definition of "whitespace," but I guess that I can live with
being consistent to NormalizeWhitespace().

[sergei, 2018/03/01 15:05:24]

It's not about whitespaces, it's only for spaces, it can be extended later as we
need it.

+      break;
+
+  for (; end > 0; end--)

[Wladimir Palant, 2017/12/21 10:30:35]

You should check for `end > start` here. Otherwise you will end up with a
negative length for whitespace-only strings (meaning a huge length because the
values are unsigned).

[sergei, 2018/03/01 15:05:24]

Done, it's covered in tests.

+    if (value[end - 1] > u' ')
+      break;
+  return DependentString(value, start, end - start);
+}

[Wladimir Palant, 2017/12/21 10:30:35]

All string methods are inlined, why did you put this one into a separate file?

[sergei, 2018/03/01 15:05:25]

I moved SplitString into cpp too because when it's inlined it generates a lot of
code. Since it's easier to use it in the development when it's in cpp file,
let's hope that the linker is smart enough to optimize it.