compiled/subscription/DownloadableSubscription.h - Issue 29548581: Issue 4128, 5138 - Add Parser and Serializer implemented in C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/subscription/DownloadableSubscription.h

Issue 29548581: Issue 4128, 5138 - Add Parser and Serializer implemented in C++ Base URL: https://github.com/adblockplus/adblockpluscore.git

Patch Set: Created Sept. 18, 2017, 5:23 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: compiled/subscription/DownloadableSubscription.h

diff --git a/compiled/subscription/DownloadableSubscription.h b/compiled/subscription/DownloadableSubscription.h

index 49cf9c45a78fa9734b907331f5fc0f6a3d103b92..bcb1c08fcf8d893ca5a7256d7f43b405611dad9a 100644

--- a/compiled/subscription/DownloadableSubscription.h

+++ b/compiled/subscription/DownloadableSubscription.h

@@ -25,7 +25,7 @@

class DownloadableSubscription : public Subscription

{

public:

- explicit DownloadableSubscription(const String& id);

+ explicit DownloadableSubscription(const String& id, const KeyValues& properties);

Wladimir Palant 2017/12/21 10:30:38 I'd rather not have properties as an additional co

SUBSCRIPTION_PROPERTY(bool, mFixedTitle, SUBSCRIPTION_FIXEDTITLE,

GetFixedTitle, SetFixedTitle);

@@ -52,7 +52,7 @@ public:

SUBSCRIPTION_PROPERTY(int, mDownloadCount, NONE,

GetDownloadCount, SetDownloadCount);

- OwnedString BINDINGS_EXPORTED Serialize() const;

+ OwnedString SerializeProperties() const;

};

template<>