Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 29549604: Issue 5729 - remove_redundant_translations fails due to the presence of system file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by jens
Modified:
1 year, 10 months ago
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5729 - remove_redundant_translations fails due to the presence of system file

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Removed Windows part #

Total comments: 2

Patch Set 3 : removed simicolons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M translations.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9
jens
1 year, 11 months ago (2017-09-19 10:08:51 UTC) #1
diegocarloslima
On 2017/09/19 10:08:51, jens wrote: LGTM. I made just a small observation in one of ...
1 year, 11 months ago (2017-09-19 20:03:45 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29549604/diff/29549714/translations.py File translations.py (right): https://codereview.adblockplus.org/29549604/diff/29549714/translations.py#newcode86 translations.py:86: # ignore system files I think you can change ...
1 year, 11 months ago (2017-09-19 20:03:55 UTC) #3
Vasily Kuznetsov
Hi Jens, The changes look good in general, but I'm not quite sure about the ...
1 year, 11 months ago (2017-09-19 21:48:05 UTC) #4
jens
On 2017/09/19 21:48:05, Vasily Kuznetsov wrote: > Hi Jens, > > The changes look good ...
1 year, 11 months ago (2017-09-20 08:38:03 UTC) #5
jens
https://codereview.adblockplus.org/29549604/diff/29549714/translations.py File translations.py (right): https://codereview.adblockplus.org/29549604/diff/29549714/translations.py#newcode86 translations.py:86: # ignore system files On 2017/09/19 20:03:54, diegocarloslima wrote: ...
1 year, 11 months ago (2017-09-20 08:38:12 UTC) #6
Vasily Kuznetsov
Hi Jens, I just have one linguistic nit (see below) but otherwise it looks good. ...
1 year, 11 months ago (2017-09-22 16:27:10 UTC) #7
jens
https://codereview.adblockplus.org/29549604/diff/29550638/translations.py File translations.py (right): https://codereview.adblockplus.org/29549604/diff/29550638/translations.py#newcode86 translations.py:86: continue; On 2017/09/22 16:27:10, Vasily Kuznetsov wrote: > You ...
1 year, 11 months ago (2017-09-26 12:09:18 UTC) #8
Vasily Kuznetsov
1 year, 11 months ago (2017-09-26 13:13:38 UTC) #9
On 2017/09/26 12:09:18, jens wrote:
> https://codereview.adblockplus.org/29549604/diff/29550638/translations.py
> File translations.py (right):
> 
>
https://codereview.adblockplus.org/29549604/diff/29550638/translations.py#new...
> translations.py:86: continue;
> On 2017/09/22 16:27:10, Vasily Kuznetsov wrote:
> > You don't need the semicolon at the end of the line.
> 
> Ah, you're right. I know it's not necessary in python but it's just a habit
from
> doing Java all the time.

Yeah, I know. Happens to the best of us when one tries to juggle multiple
languages. LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5