Issue 5535 - Replace our module system with webpack

webpack_runner.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 const path = require("path");
+const process = require("process");
+
+const MemoryFS = require("memory-fs");
+const webpack = require("webpack");
 
 let {EXTENSION_PATH, ENTRY_POINTS, OUTPUT_PATH, BUNDLE_NAME,
-     RESOLVE_PATHS, INFO_PATH} = require("process").env;
+     RESOLVE_PATHS} = require("process").env;
 
-module.exports = {
+// Copied from adblockpluscore/test_runner.js
+function webpackInMemory(bundleFilename, options)
+{
+  return new Promise((resolve, reject) =>
+  {
+    // Based on this example
+    // https://webpack.js.org/api/node/#custom-file-systems
+    let memoryFS = new MemoryFS();
+
+    options.output = {filename: bundleFilename, path: "/"};
+    let webpackCompiler = webpack(options);
+    webpackCompiler.outputFileSystem = memoryFS;
+
+    webpackCompiler.run((err, stats) =>
+    {
+      // Error handling is based on this example
+      // https://webpack.js.org/api/node/#error-handling
+      if (err)
+      {
+        let reason = err.stack || err;
+        if (err.details)
+          reason += "\n" + err.details;
+        reject(reason);
+      }
+      else if (stats.hasErrors())
+        reject(stats.toJson().errors);
+      else
+      {
+        let bundle = memoryFS.readFileSync("/" + bundleFilename, "utf-8");
+        memoryFS.unlinkSync("/" + bundleFilename);
+        resolve(bundle);
+      }
+    });
+  });
+}
+
+webpackInMemory(BUNDLE_NAME, {
   context: EXTENSION_PATH,
-  devtool: "source-map",
+  devtool: "inline-source-map",
   entry: ENTRY_POINTS.split(" "),
+  module: {
+    rules: [{
+      test: /info.js$/,
+      use: ["info-loader"]
+    }]
+  },
   output: {
     path: OUTPUT_PATH,
     filename: BUNDLE_NAME
   },
   resolve: {
     modules: RESOLVE_PATHS.split(" "),
     alias: {
-      info$: INFO_PATH,
       // Prevent builtin Node.js modules from being used instead of our own when
       // the names clash. Once relative paths are used this won't be necessary.
       url$: "url.js",
       events$: "events.js",
       punycode$: "punycode.js"
     },
     plugins: [
       function()
       {
         // Our old module system in packagerChrome.py used to prefix
@@ skipping 19 matching lines @@
           return this.doResolve(
             "resolve", Object.assign({}, request, {request: fixed_target}),
             "Changed prefixed path using legacy buildtools syntax from " +
             target + " to " + fixed_target,
             callback
           );
         });
       }
     ]
   },
+  resolveLoader: {
+    modules: [path.resolve(__dirname)]
+  },
   stats: {
     assets: false,
     children: false,
     chunks: false,
     errorDetails: true,
     errors: true,
     hash: false,
     modules: false,
     publicPath: false,
     reasons: false,
     source: false,
     timings: false,
     version: false,
     warnings: true
   }
-};
+}).then(console.log, e =>
+{
+  // I would prefer to simply leave the exception unhandled, since we want the
+  // script to end in that case. Unfortunatley though Node.js displays a
+  // deprecation warning if we do:
+  //   "[DEP0018] DeprecationWarning: Unhandled promise rejections are
+  //    deprecated. In the future, promise rejections that are not handled
+  //    will terminate the Node.js process with a non-zero exit code."
+  console.error(e.join("\n"));
+  process.exit(1);
+});