Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: info.js
Issue
29549786
:
Issue 5535 - Replace our module system with webpack (Closed)
Left Patch Set: Fixed spelling mistake
Created Sept. 19, 2017, 2:49 p.m.
Right Patch Set: Addressed final nits
Created Oct. 10, 2017, 5:02 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Fixed spelling mistake
Patch Set 3: Silence webpack output except errors and warnings
Patch Set 4: Delete all temporary files at the same time
Patch Set 5: Addressed Sebastian's feedback
Patch Set 6: Hardcode resolve paths
Patch Set 7: Improved resolve paths comment
Patch Set 8: Removed ext_background workaround
Patch Set 9: Use absolute paths for entry points
Patch Set 10: Avoid writing files when producing webpack bundles
Patch Set 11: Only use special info-loader for adblockpluschrome/lib/info.js
Patch Set 12: Expose stats Object
Patch Set 13: Improve output on error
Patch Set 14: Addressed Wladimir's feedback
Patch Set 15: Tidy up JSON passed from packagerChrome.py
Patch Set 16: Produce all bundles in one Node.js process to speed things up
Patch Set 17: Avoid creating multiple webpack compilers
Patch Set 18: Fixed tox errors
Patch Set 19: Addressed Wladimir's feedback, use JSON and standard in + out
Patch Set 20: Rebased and tidied up
Patch Set 21: Addressed final nits
Right:
Patch Set 1: None
Patch Set 2: Fixed spelling mistake
Patch Set 3: Silence webpack output except errors and warnings
Patch Set 4: Delete all temporary files at the same time
Patch Set 5: Addressed Sebastian's feedback
Patch Set 6: Hardcode resolve paths
Patch Set 7: Improved resolve paths comment
Patch Set 8: Removed ext_background workaround
Patch Set 9: Use absolute paths for entry points
Patch Set 10: Avoid writing files when producing webpack bundles
Patch Set 11: Only use special info-loader for adblockpluschrome/lib/info.js
Patch Set 12: Expose stats Object
Patch Set 13: Improve output on error
Patch Set 14: Addressed Wladimir's feedback
Patch Set 15: Tidy up JSON passed from packagerChrome.py
Patch Set 16: Produce all bundles in one Node.js process to speed things up
Patch Set 17: Avoid creating multiple webpack compilers
Patch Set 18: Fixed tox errors
Patch Set 19: Addressed Wladimir's feedback, use JSON and standard in + out
Patch Set 20: Rebased and tidied up
Patch Set 21: Addressed final nits
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
info.js
info-loader.js
package.json
package-lock.json
packagerChrome.py
packagerEdge.py
templates/modules.js.tmpl
webpack_runner.js
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« no previous file
|
info-loader.js »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
/* This file is required to exist by webpack, but its contents are ignored! */
LEFT
RIGHT
« no previous file
|
info-loader.js »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 29549786: Issue 5535 - Replace our module system with webpack (Closed)
Created Sept. 19, 2017, 2:23 p.m. by kzar
Modified Oct. 10, 2017, 6:08 p.m.
Reviewers: Sebastian Noack, Wladimir Palant
Base URL:
Comments: 58
This is Rietveld