packagerSafari.py - Issue 29549786: Issue 5535 - Replace our module system with webpack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: packagerSafari.py

Issue 29549786: Issue 5535 - Replace our module system with webpack (Closed)

Patch Set: Removed ext_background workaround Created Sept. 25, 2017, 3:17 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: packagerSafari.py

diff --git a/packagerSafari.py b/packagerSafari.py

index 288ba8d467e81ecbadd6146285e8d35f0f6d09f7..241ac201e958f0f92e3c0b6ee104b01cd2b50834 100644

--- a/packagerSafari.py

+++ b/packagerSafari.py

@@ -10,7 +10,7 @@ import re

from urlparse import urlparse

from packager import readMetadata, getDefaultFileName, getBuildVersion, getTemplate, Files

-from packagerChrome import convertJS, import_locales, getIgnoredFiles, getPackageFiles, defaultLocale, createScriptPage

+from packagerChrome import create_bundles, import_locales, getIgnoredFiles, getPackageFiles, defaultLocale, createScriptPage

def processFile(path, data, params):

@@ -144,8 +144,8 @@ def createBuild(baseDir, type, outFile=None, buildNum=None, releaseBuild=False,

files.readMappedFiles(mapped)

files.read(baseDir, skip=[opt for opt, _ in mapped])

- if metadata.has_section('convert_js'):

- convertJS(params, files)

+ if metadata.has_section('bundles'):

+ create_bundles(params, files)

if metadata.has_section('preprocess'):

files.preprocess(