Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: new-options.js

Issue 29549891: Issue 5706 - Finish custom filter list dialog (Closed)
Patch Set: Addressed Ire's comments Created Sept. 21, 2017, 7:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « new-options.html ('k') | skin/icons/attention.svg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: new-options.js
===================================================================
--- a/new-options.js
+++ b/new-options.js
@@ -677,6 +677,23 @@
url: findParentData(element, "access", false)
});
break;
+ case "validate-import-subscription":
+ let form = findParentData(element, "validation", true);
+ if (!form)
+ return;
+
+ if (form.checkValidity())
+ {
+ addEnableSubscription(E("import-list-url").value,
ire 2017/09/22 08:28:53 NIT: I'm getting an eslint error here: "no-trailin
saroyanm 2017/09/22 09:46:58 Done.
+ E("import-list-title").value);
+ form.reset();
+ closeDialog();
+ }
+ else
+ {
+ form.querySelector(":invalid").focus();
+ }
+ break;
}
}
« no previous file with comments | « new-options.html ('k') | skin/icons/attention.svg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld