Issue 5735 - Use JS Map instead of Object for Filter.knownFilters

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 319 matching lines @@
   },
 
   /**
    * Resets hit count for some filters
    * @param {Filter[]} filters  filters to be reset, if null all filters will
    *                            be reset
    */
   resetHitCounts(filters)
   {
     if (!filters)
     {

[Wladimir Palant, 2017/09/20 08:59:10]

Nit: You can remove the brackets around this block.

[sergei, 2017/09/20 09:22:40]

Done.

-      filters = [];
-      for (let text in Filter.knownFilters)
-        filters.push(Filter.knownFilters[text]);
+      filters = Filter.knownFilters.values();
     }
     for (let filter of filters)
     {
       filter.hitCount = 0;
       filter.lastHit = 0;
     }
   },
 
   /**
    * @callback TextSink
@@ skipping 334 matching lines @@
 }
 
 /**
  * Listener returned by FilterStorage.importData(), parses filter data.
  * @constructor
  */
 function INIParser()
 {
   this.fileProperties = this.curObj = {};
   this.subscriptions = [];
-  this.knownFilters = Object.create(null);
+  this.knownFilters = new Map();
   this.knownSubscriptions = Object.create(null);
 }
 INIParser.prototype =
 {
   linesProcessed: 0,
   subscriptions: null,
   knownFilters: null,
   knownSubscriptions: null,
   wantObj: true,
   fileProperties: null,
@@ skipping 68 matching lines @@
       else if (this.wantObj === false && val)
         this.curObj.push(val.replace(/\\\[/g, "["));
     }
     finally
     {
       Filter.knownFilters = origKnownFilters;
       Subscription.knownSubscriptions = origKnownSubscriptions;
     }
   }
 };