Noissue - rename variable 'ret' to more meaningful 'filter' in lib/filterClasses.js

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 90 matching lines @@
 
 /**
  * Creates a filter of correct type from its text representation - does the
  * basic parsing and calls the right constructor then.
  *
  * @param {string} text   as in Filter()
  * @return {Filter}
  */
 Filter.fromText = function(text)
 {
-  let ret = Filter.knownFilters.get(text);
-  if (ret)
-    return ret;
+  let filter = Filter.knownFilters.get(text);
+  if (filter)
+    return filter;
 
   let match = (text.includes("#") ? Filter.elemhideRegExp.exec(text) : null);
   if (match)
   {
     let propsMatch;
     if (!match[2] &&
         (propsMatch = /\[-abp-properties=(["'])([^"']+)\1\]/.exec(match[3])))
     {
       // This is legacy CSS properties syntax, convert to current syntax
       let prefix = match[3].substr(0, propsMatch.index);
       let expression = propsMatch[2];
       let suffix = match[3].substr(propsMatch.index + propsMatch[0].length);
       return Filter.fromText(`${match[1]}#?#` +
           `${prefix}:-abp-properties(${expression})${suffix}`);
     }
 
-    ret = ElemHideBase.fromText(
+    filter = ElemHideBase.fromText(
       text, match[1], match[2], match[3]
     );
   }
   else if (text[0] == "!")
-    ret = new CommentFilter(text);
+    filter = new CommentFilter(text);
   else
-    ret = RegExpFilter.fromText(text);
+    filter = RegExpFilter.fromText(text);
 
-  Filter.knownFilters.set(ret.text, ret);
-  return ret;
+  Filter.knownFilters.set(filter.text, filter);
+  return filter;
 };
 
 /**
  * Deserializes a filter
  *
  * @param {Object}  obj map of serialized properties and their values
  * @return {Filter} filter or null if the filter couldn't be created
  */
 Filter.fromObject = function(obj)
 {
-  let ret = Filter.fromText(obj.text);
-  if (ret instanceof ActiveFilter)
+  let filter = Filter.fromText(obj.text);
+  if (filter instanceof ActiveFilter)
   {
     if ("disabled" in obj)
-      ret._disabled = (obj.disabled == "true");
+      filter._disabled = (obj.disabled == "true");
     if ("hitCount" in obj)
-      ret._hitCount = parseInt(obj.hitCount, 10) || 0;
+      filter._hitCount = parseInt(obj.hitCount, 10) || 0;
     if ("lastHit" in obj)
-      ret._lastHit = parseInt(obj.lastHit, 10) || 0;
+      filter._lastHit = parseInt(obj.lastHit, 10) || 0;
   }
-  return ret;
+  return filter;
 };
 
 /**
  * Removes unnecessary whitespaces from filter text, will only return null if
  * the input parameter is null.
  * @param {string} text
  * @return {string}
  */
 Filter.normalize = function(text)
 {
@@ skipping 849 matching lines @@
  */
 function ElemHideEmulationFilter(text, domains, selector)
 {
   ElemHideBase.call(this, text, domains, selector);
 }
 exports.ElemHideEmulationFilter = ElemHideEmulationFilter;
 
 ElemHideEmulationFilter.prototype = extend(ElemHideBase, {
   type: "elemhideemulation"
 });