Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29551585: #2317 - provide role fileserver for eyeofiles.com (Closed)

Created:
Sept. 21, 2017, 8:46 a.m. by f.nicolaisen
Modified:
Sept. 29, 2017, 10:31 a.m.
Reviewers:
f.lopez, mathias, mahtias
Base URL:
https://hg1/infrastructure
Visibility:
Public.

Description

#2317 - provide role fileserver for eyeofiles.com

Patch Set 1 #

Total comments: 18

Patch Set 2 : move into adblockplus::web namespace and other improvements #

Patch Set 3 : replace hardcoded repository with definition #

Total comments: 16

Patch Set 4 : make repository into subdomains #

Patch Set 5 : use single nginx conf based on $host #

Total comments: 14

Patch Set 6 : more flexible resource definitions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -0 lines) Patch
A hiera/roles/web/fileserver/eyeofiles.yaml View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A modules/adblockplus/files/nginx/fileserver.conf View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/web/fileserver.pp View 1 2 3 4 5 1 chunk +56 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/web/fileserver/repository.pp View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12
f.nicolaisen
Sept. 21, 2017, 8:46 a.m. (2017-09-21 08:46:53 UTC) #1
mathias
https://codereview.adblockplus.org/29551585/diff/29551586/modules/fileserver/manifests/init.pp File modules/fileserver/manifests/init.pp (right): https://codereview.adblockplus.org/29551585/diff/29551586/modules/fileserver/manifests/init.pp#newcode2 modules/fileserver/manifests/init.pp:2: class fileserver( This should be an entity within namespace ...
Sept. 21, 2017, 11:43 a.m. (2017-09-21 11:43:20 UTC) #2
f.nicolaisen
https://codereview.adblockplus.org/29551585/diff/29551586/modules/fileserver/manifests/init.pp File modules/fileserver/manifests/init.pp (right): https://codereview.adblockplus.org/29551585/diff/29551586/modules/fileserver/manifests/init.pp#newcode2 modules/fileserver/manifests/init.pp:2: class fileserver( On 2017/09/21 11:43:20, mathias wrote: > This ...
Sept. 21, 2017, 2:17 p.m. (2017-09-21 14:17:13 UTC) #3
f.nicolaisen
PS2 addresses all the comments. I wasn't sure how to work with the virtual resources, ...
Sept. 21, 2017, 8:43 p.m. (2017-09-21 20:43:40 UTC) #4
f.nicolaisen
On 2017/09/21 20:43:40, f.nicolaisen wrote: > PS2 addresses all the comments. I wasn't sure how ...
Sept. 21, 2017, 9:35 p.m. (2017-09-21 21:35:04 UTC) #5
mathias
https://codereview.adblockplus.org/29551585/diff/29551713/modules/adblockplus/files/nginx/fileserver.conf File modules/adblockplus/files/nginx/fileserver.conf (right): https://codereview.adblockplus.org/29551585/diff/29551713/modules/adblockplus/files/nginx/fileserver.conf#newcode4 modules/adblockplus/files/nginx/fileserver.conf:4: location / Actually the idea was to use sub-domains ...
Sept. 22, 2017, 7 a.m. (2017-09-22 07:00:15 UTC) #6
f.nicolaisen
https://codereview.adblockplus.org/29551585/diff/29551713/modules/adblockplus/files/nginx/fileserver.conf File modules/adblockplus/files/nginx/fileserver.conf (right): https://codereview.adblockplus.org/29551585/diff/29551713/modules/adblockplus/files/nginx/fileserver.conf#newcode4 modules/adblockplus/files/nginx/fileserver.conf:4: location / On 2017/09/22 07:00:14, mathias wrote: > Actually ...
Sept. 22, 2017, 7:57 a.m. (2017-09-22 07:57:44 UTC) #7
mathias
Didn't you want switch to the directory terminology? https://codereview.adblockplus.org/29551585/diff/29555710/modules/adblockplus/files/nginx/fileserver.conf File modules/adblockplus/files/nginx/fileserver.conf (right): https://codereview.adblockplus.org/29551585/diff/29555710/modules/adblockplus/files/nginx/fileserver.conf#newcode1 modules/adblockplus/files/nginx/fileserver.conf:1: # ...
Sept. 25, 2017, 5:06 p.m. (2017-09-25 17:06:04 UTC) #8
f.nicolaisen
> Didn't you want switch to the directory terminology? I'm not sure. I mused a ...
Sept. 25, 2017, 8:21 p.m. (2017-09-25 20:21:19 UTC) #9
mathias
https://codereview.adblockplus.org/29551585/diff/29555710/modules/adblockplus/files/nginx/fileserver.conf File modules/adblockplus/files/nginx/fileserver.conf (right): https://codereview.adblockplus.org/29551585/diff/29555710/modules/adblockplus/files/nginx/fileserver.conf#newcode1 modules/adblockplus/files/nginx/fileserver.conf:1: # Generated by puppet module adblockplus::web::fileserver On 2017/09/25 20:21:18, ...
Sept. 25, 2017, 9:08 p.m. (2017-09-25 21:08:51 UTC) #10
f.nicolaisen
PS6 addresses these plus the acks in my previous mail. https://codereview.adblockplus.org/29551585/diff/29555710/modules/adblockplus/files/nginx/fileserver.conf File modules/adblockplus/files/nginx/fileserver.conf (right): https://codereview.adblockplus.org/29551585/diff/29555710/modules/adblockplus/files/nginx/fileserver.conf#newcode1 ...
Sept. 25, 2017, 9:19 p.m. (2017-09-25 21:19:47 UTC) #11
mathias
Sept. 26, 2017, 9:34 a.m. (2017-09-26 09:34:05 UTC) #12
LGTM.

Powered by Google App Engine
This is Rietveld