Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29551727: Issue 5634 - Removed search from abp.org header (Closed)

Created:
Sept. 21, 2017, 10:44 p.m. by juliandoucette
Modified:
Sept. 25, 2017, 2:40 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5634 - Removed search from abp.org header

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -123 lines) Patch
M locales/en/menu.json View 1 chunk +0 lines, -3 lines 2 comments Download
M static/css/main.css View 1 chunk +0 lines, -16 lines 0 comments Download
M static/css/main-desktop.css View 2 chunks +1 line, -65 lines 0 comments Download
M static/css/main-mobile.css View 1 chunk +0 lines, -28 lines 0 comments Download
M templates/default.tmpl View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
Sept. 21, 2017, 10:45 p.m. (2017-09-21 22:45:03 UTC) #1
ire
See my question below. Otherwise, LGTM https://codereview.adblockplus.org/29551727/diff/29551728/locales/en/menu.json File locales/en/menu.json (left): https://codereview.adblockplus.org/29551727/diff/29551728/locales/en/menu.json#oldcode18 locales/en/menu.json:18: "message": "Search" Should ...
Sept. 22, 2017, 8:45 a.m. (2017-09-22 08:45:49 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29551727/diff/29551728/locales/en/menu.json File locales/en/menu.json (left): https://codereview.adblockplus.org/29551727/diff/29551728/locales/en/menu.json#oldcode18 locales/en/menu.json:18: "message": "Search" On 2017/09/22 08:45:49, ire wrote: > Should ...
Sept. 22, 2017, 11:34 a.m. (2017-09-22 11:34:07 UTC) #3
ire
On 2017/09/22 11:34:07, juliandoucette wrote: > https://codereview.adblockplus.org/29551727/diff/29551728/locales/en/menu.json > File locales/en/menu.json (left): > > https://codereview.adblockplus.org/29551727/diff/29551728/locales/en/menu.json#oldcode18 > ...
Sept. 22, 2017, 11:50 a.m. (2017-09-22 11:50:52 UTC) #4
juliandoucette
Sept. 25, 2017, 2:40 p.m. (2017-09-25 14:40:23 UTC) #5

Powered by Google App Engine
This is Rietveld